Add role info (core/support)

[Tsury]

Is it possible to add role info (core/support)? It might be obtained from GPM/wards purchased.
I'm not interested in specific position (1-5), but just whether a given player was a core (1-3) or a support (4-5).

[howardchung]

currently for the analysis page we just base it off wards placed (>2) and less than 20 last hits at 10 minutes:
https://github.com/odota/web/blob/5436c56f491b1d9b759147407f9a48eb7d022570/src/utility/index.jsx#L257

You can compute the same value statically from a match data blob.

[Tsury]

Sorry, I wasn't being clear. There's no way to retrieve this information without getting the match data blob, which means that if needed to obtain for multiple matches, one has to fetch and calculate for all of them separately. I feel like role is parallel to lane, in category/importance and should be /players/matches and /players/recentMatches. Is that something you can consider adding?

[howardchung]

It could be added for future matches, but currently isn't saved to the cassandra player_caches table so can't be returned for each player-match

[Tsury]

Sounds good to me, future matches is fine. Thanks!

[ahi-el]

I'm guessing this was before ranked roles were introduced. Do we get the roles now?

[howardchung]

I have not played ranked roles. Is it available in the post-match stats in client?

[ahi-el]

I didn't find anything in 'ranked' matches, but there is a field that describes it well

This is from the data that is used in Table (in web)

Note - while this was accurate for 1 team, for the other team it displayed both offlane players as core, even though one of them was clearly support since he took no last hits, so it might be somewhat innaccurate

link to match with inaccurate desc: https://www.opendota.com/matches/5109807012/overview

[howardchung]

We calculate support-ness just by the last hit at 10 minutes count and ward placement, see https://github.com/odota/web/blob/master/src/actions/transformMatch.js#L151 and the isSupport function in utility.

[howardchung]

The reason that it's in the client side code and not returned in the API/server is that we were aware that it would probably be somewhat inaccurate to guess using these metrics and wanted the flexibility to change it