estate module: Write importable modules tutorial #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…d created the x_estate_property_type model
… one2many field to a property + refactor the model definitions in a separated file
…del and update views to include it
…update related fields
…es for public access
frva-odoo
reviewed
Jun 4, 2025
vava-odoo
reviewed
Jun 6, 2025
There was a problem hiding this comment.
Good job @arthurrrm !
Don't hesitate to ask if one of my comment is unclear or does not make sense. Most of these are suggestions, so we can discuss pros / cons if you like.
Cheers!
vava-odoo
reviewed
Jun 10, 2025
Comment on lines
+90
to
+91
| <field name="compute"><![CDATA[for property in self: | ||
| property['x_garden_area'] = 0 if not property.x_garden else 1000 |
There was a problem hiding this comment.
back to this: this is not correct. It is in an onchange, to set back to a default value when editing the boolean in the form. But here you would totally erase the value entered by the user.
Comment on lines
+8
to
+13
| for offer in records: | ||
| offer.write({'x_status': 'accepted'}) | ||
| offer.x_property_id.write({'x_selling_price': offer.x_price, 'x_partner_id': offer.x_partner_id}) | ||
| for other_offer in offer.x_property_id.x_offer_ids: | ||
| if other_offer != offer: | ||
| other_offer.write({'x_status': 'refused'}) |
There was a problem hiding this comment.
Ok, but what if you accept two offers for the same property? It seems like only one will be accepted, but it is kind of magic, no? Shouldn't we take more care (and maybe raise in such cases)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.