[ADD] estate: created a platform for customers to sell and buy properties. #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new module named Estate. Completed till the basic ui of the module.
Created relational models, Computed fields, and On Changes. Completed 8 modules out of 15.
Cleaned the code according to the coding standards Completed 8 modules out of 15.
Completed the module along with the coding standards
When trying to delete a property, there was a validation issue which is resolved in this commit. Cleaned the code according to the coding conventions.
Made changes in the estate property schema as well
Implemented access rules for the users. Added a new field named company_id in the estate property model.
|
|
aktr-odoo
suggested changes
Dec 23, 2024
| @@ -0,0 +1,15 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <odoo> | |||
| <record id="estate_property_type_id1" model="estate.property.type"> | |||
There was a problem hiding this comment.
Try to give proper names. Avoid _id1
estate/models/__init__.py
Outdated
Comment on lines
2
to
4
| from . import estate_property_type | ||
| from . import estate_property_tags | ||
| from . import estate_property_offer |
Comment on lines
+9
to
+15
| user_id = fields.Many2one( | ||
| "res.users", | ||
| string="Salesperson", | ||
| index=True, | ||
| tracking=True, | ||
| default=lambda self: self.env.user, | ||
| ) |
estate/models/estate_property.py
Outdated
Comment on lines
29
to
42
| garden_orientation = fields.Selection( | ||
| [("north", "North"), ("south", "South"), ("east", "East"), ("west", "West")], | ||
| "Garden Orientation" | ||
| ) | ||
| state = fields.Selection( | ||
| [ | ||
| ("new", "New"), | ||
| ("offer_received", "Offer Received"), | ||
| ("offer_accepted", "Offer Accepted"), | ||
| ("sold", "Sold"), | ||
| ("cancelled", "Cancelled"), | ||
| ], | ||
| default="new", | ||
| ) |
Comment on lines
+51
to
+62
| _sql_constraints = [ | ||
| ( | ||
| "check_expected_price", | ||
| "CHECK(expected_price >= 0)", | ||
| "A property expected price must be strictly positive", | ||
| ), | ||
| ( | ||
| "check_selling_price", | ||
| "CHECK(selling_price >= 0)", | ||
| "A property selling price must be positive", | ||
| ), | ||
| ] |
| "You cannot delete a property that is not in New or Cancelled state." | ||
| ) | ||
|
|
||
| def action_change_state(self): |
|
|
||
| @api.model | ||
| def create(self, vals): | ||
| property_id = vals.get("property_id") |
There was a problem hiding this comment.
This wont work if multiple records are created. i.e. getting list of dict in vals
There was a problem hiding this comment.
We don't have the functionality to add multiple offers for one property at a time, so do we need to implement this in our module?
There was a problem hiding this comment.
but what if someone creates property by importing a file that has multiple offers
estate/security/ir.model.access.csv
Outdated
Comment on lines
2
to
9
| 1,access_estate_property,model_estate_property,estate.estate_group_manager,1,1,1,1 | ||
| 2,access_estate_property_type,model_estate_property_type,estate.estate_group_manager,1,1,1,1 | ||
| 3,access_estate_property_tags,model_estate_property_tags,estate.estate_group_manager,1,1,1,1 | ||
| 4,access_estate_property_offer,model_estate_property_offer,estate.estate_group_manager,1,1,1,1 | ||
| 5,access_estate_property,model_estate_property,estate.estate_group_user,1,1,1,0 | ||
| 6,access_estate_property_type,model_estate_property_type,estate.estate_group_user,1,0,0,0 | ||
| 7,access_estate_property_tags,model_estate_property_tags,estate.estate_group_user,1,0,0,0 | ||
| 8,access_estate_property_offer,model_estate_property_offer,estate.estate_group_user,1,1,1,1 |
There was a problem hiding this comment.
ids as 1,2,3?
Refer codebase and correct it
| </list> | ||
| </field> | ||
| </record> | ||
|
|
| <field name="res_model">estate.property</field> | ||
| <field name="view_mode">list,form,kanban</field> | ||
| <field name="context">{'search_default_active': True, 'search_default_current': True}</field> | ||
| </record> |
… and users. This commit includes: 1) Implementation of a wizard to add a single offer to multiple properties. 2) Download reports for multiple properties and users. 3) Code cleaning according to the coding conventions.
Features added: 1) User can create their WhatsApp templates. 2) A WhatsApp message will be sent to the buyer when the property is sold.
Specification: 1) Different warranty configurations can be created. Example- 1 year, 2 year. 2) Warranty can be added for products in the sales order.
chkh-odoo
force-pushed
the
18.0-training-chkh
branch
from
fe5c060 to
ad69395
Compare
What I have fixed: 1) If the user deletes the product from the sale order line, the attached warranty will also be deleted. 2) If a product is attached with a warranty it will not show in the wizard list.
chkh-odoo
force-pushed
the
18.0-training-chkh
branch
from
38c55c0 to
1cba226
Compare
Changes made: 1) removed the wizard_id field as there was a pre-created field in the sale order line i.e. linked_line_id.
Before this commit: The warranty was not being deleted on the click of the delete button for the sale order line or related product. After This commit: The warranty is deleted on the click of the delete button for the sale order line or related product.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new module named Estate.