Skip to content

Conversation

@fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Oct 20, 2025

In some case a process could remain active at the end of a tests In addition to possible race condition, this can also cause a program to remain stuck at the end of the tests.

This commit proposes to

  • catch all remaining processes at the end of a base case.
  • log a message if a process is found at the shutdown of the server.

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #231942

@robodoo
Copy link
Contributor

robodoo commented Oct 20, 2025

Pull request status dashboard

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Oct 20, 2025
@fw-bot
Copy link
Contributor Author

fw-bot commented Oct 20, 2025

@Xavier-Do cherrypicking of pull request #231942 failed.

stdout:

Auto-merging odoo/service/server.py
CONFLICT (content): Merge conflict in odoo/service/server.py
Auto-merging odoo/tests/common.py

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

In some case a process could remain aive at the end of a tests
In addition to possible race condition, this can also cause a program to
remain stuck at the end of the tests.

This commit proposes to
- catch all remaining processes at the end of a base case.
- log a message if a process is found at the shutdown of the server.

X-original-commit: 5f7f138
@Xavier-Do Xavier-Do force-pushed the master-17.0-catch-remaining-processes-xdo-471789-fw branch from 37aa1bb to 05e3c1a Compare October 21, 2025 08:40
@Xavier-Do
Copy link
Contributor

robodoo r+

@C3POdoo C3POdoo requested review from a team, Julien00859, rco-odoo and rugo-odoo and removed request for a team October 21, 2025 08:43
robodoo pushed a commit that referenced this pull request Oct 21, 2025
In some case a process could remain aive at the end of a tests
In addition to possible race condition, this can also cause a program to
remain stuck at the end of the tests.

This commit proposes to
- catch all remaining processes at the end of a base case.
- log a message if a process is found at the shutdown of the server.

closes #232424

X-original-commit: 5f7f138
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
@robodoo robodoo added the 19.1 label Oct 21, 2025
@robodoo robodoo closed this Oct 21, 2025
@fw-bot fw-bot deleted the master-17.0-catch-remaining-processes-xdo-471789-fw branch October 28, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

19.1 conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants