[FW][FIX] base_vat: support for 2020 Albanian Tax ID #114488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__Description of the issue this PR addresses:__ The first character of a Tax ID from Albania is a letter representing the decade in which it has been issued. The letter M represents the current decade. (This pdf explains in details how it is formated: https://www.oecd.org/tax/automatic-exchange/crs-implementation-and-assistance/tax-identification-numbers/Albania-TIN.pdf). Currently the way Albanian Tax IDs are validated is through the python library [`python-stdnum`](https://pypi.org/project/python-stdnum/). However, the regex that is used to validate them has not been updated since 2017. (I made a PR in its repo arthurdejong/python-stdnum#402 to fix that). The code from this commit is inspired by the one from that library, but the regex includes the letter M. __Current behavior before PR:__ (`base_vat` must be installed) By going to Settings > Users & Companies > [A company]: - Set the country to Albania - Set VAT/Tax ID to “M12345678T”. => Error message X-original-commit: f0b6e4c
|
|
|
@Dj0ulo @vin-odoo this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, say
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 7, 2023
__Description of the issue this PR addresses:__ The first character of a Tax ID from Albania is a letter representing the decade in which it has been issued. The letter M represents the current decade. (This pdf explains in details how it is formated: https://www.oecd.org/tax/automatic-exchange/crs-implementation-and-assistance/tax-identification-numbers/Albania-TIN.pdf). Currently the way Albanian Tax IDs are validated is through the python library [`python-stdnum`](https://pypi.org/project/python-stdnum/). However, the regex that is used to validate them has not been updated since 2017. (I made a PR in its repo arthurdejong/python-stdnum#402 to fix that). The code from this commit is inspired by the one from that library, but the regex includes the letter M. __Current behavior before PR:__ (`base_vat` must be installed) By going to Settings > Users & Companies > [A company]: - Set the country to Albania - Set VAT/Tax ID to “M12345678T”. => Error message closes #114488 X-original-commit: f0b6e4c Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
fw-bot
deleted the
master-14.0-base_vat-fix-albanian-tax-id-jula-1DCQ-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue this PR addresses:
The first character of a Tax ID from Albania is a letter representing the decade in which it has been issued. The letter M represents the current decade. (This pdf explains in details how it is formated: https://www.oecd.org/tax/automatic-exchange/crs-implementation-and-assistance/tax-identification-numbers/Albania-TIN.pdf).
Currently the way Albanian Tax IDs are validated is through the python library
python-stdnum. However, the regex that is used to validate them has not been updated since 2017. (I made a PR in its repo arthurdejong/python-stdnum#402 to fix that).The code from this commit is inspired by the one from that library, but the regex includes the letter M.
Current behavior before PR:
(
base_vatmust be installed)By going to Settings > Users & Companies > [A company]:
=> Error message
Forward-Port-Of: #114006