Skip to content

[FIX] package: add swc binaries to optional dependencies#7148

Closed
fw-bot wants to merge 1 commit into18.0from
18.0-17.0-fix-test-pro-463988-fw
Closed

[FIX] package: add swc binaries to optional dependencies#7148
fw-bot wants to merge 1 commit into18.0from
18.0-17.0-fix-test-pro-463988-fw

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Sep 17, 2025

Release commit 8c68f3d has been done with Node.js v22.19.0 and NPM v10.9.3.
But in the meantime, NPM had an issue that affected the package-lock.json by pruning OS optional dependencies (See npm/cli#7961). The issue has been fixed (npm/cli#8184) in NPM v11.3 but not backported.

During the release process, we ran npm install, and so the package-lock.json was updated to remove the optional dependencies for swc binaries. Which caused issues for users each time they run npm install as they were not present anymore in the package-lock.json.

This commit adds the swc binaries to the optional dependencies of this project to avoid them being pruned again in the future.

Task: 0

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7147

@robodoo
Copy link
Collaborator

robodoo commented Sep 17, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Sep 17, 2025

@pro-odoo @LucasLefevre cherrypicking of pull request #7147 failed.

stdout:

Auto-merging package-lock.json
CONFLICT (content): Merge conflict in package-lock.json
Auto-merging package.json

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Release commit 8c68f3d has been done with
Node.js v22.19.0 and NPM v10.9.3.
But in the meantime, NPM had an issue that affected the package-lock.json
by pruning OS optional dependencies (See npm/cli#7961).
The issue has been fixed (npm/cli#8184) in NPM v11.3
but not backported.

During the release process, we ran `npm install`, and so the package-lock.json
was updated to remove the optional dependencies for swc binaries.
Which caused issues for users each time they run `npm install` as they
were not present anymore in the package-lock.json.

This commit adds the swc binaries to the optional dependencies of this
project to avoid them being pruned again in the future.

Task: 0
X-original-commit: 2612a12
@pro-odoo pro-odoo force-pushed the 18.0-17.0-fix-test-pro-463988-fw branch from bc11a3a to ef47e1c Compare September 17, 2025 07:19
@pro-odoo
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Sep 17, 2025
Release commit 8c68f3d has been done with
Node.js v22.19.0 and NPM v10.9.3.
But in the meantime, NPM had an issue that affected the package-lock.json
by pruning OS optional dependencies (See npm/cli#7961).
The issue has been fixed (npm/cli#8184) in NPM v11.3
but not backported.

During the release process, we ran `npm install`, and so the package-lock.json
was updated to remove the optional dependencies for swc binaries.
Which caused issues for users each time they run `npm install` as they
were not present anymore in the package-lock.json.

This commit adds the swc binaries to the optional dependencies of this
project to avoid them being pruned again in the future.

closes #7148

Task: 0
X-original-commit: 2612a12
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@robodoo robodoo closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants