Skip to content

[FIX] header_size: resize row based on link label instead of full link #6671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FIX] header_size: resize row based on link label instead of full link #6671

wants to merge 1 commit into from

Conversation

rmbh-odoo
Copy link
Contributor

Description:

Before this commit:

  • Row height was calculated using the full Markdown link (label + URL),
    which could lead to incorrect row resizing when word wrap was enabled.

After this commit:

  • Only the link label is used to compute row height,
    resulting in accurate sizing.

Task: 4886598

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@rmbh-odoo
[FIX] header_size: resize row based on link label instead of full link
5942d7f 
Before this commit:
- Row height was calculated using the full Markdown link (label + URL),
which could lead to incorrect row resizing when word wrap was enabled.

After this commit:
- Only the link label is used to compute row height,
resulting in accurate sizing.

Task: 4886598
@robodoo
Copy link
Collaborator

robodoo commented Jun 24, 2025

Pull request status dashboard

hokolomopo
hokolomopo reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@hokolomopo hokolomopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

robodoo pushed a commit that referenced this pull request Jul 1, 2025
@rmbh-odoo
[FIX] header_size: resize row based on link label instead of full link
d1f3c77 
Before this commit:
- Row height was calculated using the full Markdown link (label + URL),
which could lead to incorrect row resizing when word wrap was enabled.

After this commit:
- Only the link label is used to compute row height,
resulting in accurate sizing.

closes #6671

Task: 4886598
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
@fw-bot fw-bot mentioned this pull request Jul 1, 2025
Closed
14 tasks
@robodoo robodoo closed this Jul 1, 2025
This was referenced Jul 1, 2025
Closed
Closed
Closed
Closed
Closed
@fw-bot fw-bot deleted the 17.0-fix-link-row-resize-rmbh branch July 8, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hokolomopo hokolomopo hokolomopo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmbh-odoo @robodoo @hokolomopo