Skip to content

[IMP] gauge: add animation to the gauge chart #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hokolomopo
Copy link
Contributor

Description

This commit adds animations to the gauge chart in dashboard.

Task: 4788863

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented May 12, 2025

Pull request status dashboard

@hokolomopo hokolomopo force-pushed the master-gauge-chart-animation-adrm branch 2 times, most recently from 2768728 to d03bf12 Compare May 13, 2025 13:23
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done 👍
only details and one question

ctx: CanvasRenderingContext2D
): RenderingParams {
const maxValue = runtime.maxValue;
const minValue = runtime.minValue;
const gaugeValue = runtime.gaugeValue;
const gaugeValue = getGaugeValue(runtime, "current");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const gaugeValue = getGaugeValue(runtime, "current");
const gaugeValue = getGaugeValue(runtime, "animation");

?

@hokolomopo hokolomopo force-pushed the master-gauge-chart-animation-adrm branch 4 times, most recently from 5d3d6cb to e94dd1e Compare May 15, 2025 13:23
@hokolomopo hokolomopo force-pushed the master-gauge-chart-animation-adrm branch from e94dd1e to 14addcd Compare June 19, 2025 12:10
This commit adds animations to the gauge chart in dashboard.

Task: 4788863
@hokolomopo hokolomopo force-pushed the master-gauge-chart-animation-adrm branch from 14addcd to 0b26817 Compare June 23, 2025 13:27
@rrahir
Copy link
Collaborator

rrahir commented Jun 23, 2025

@robodoo r+

robodoo pushed a commit that referenced this pull request Jun 23, 2025
This commit adds animations to the gauge chart in dashboard.

closes #6377

Task: 4788863
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo added the 18.4 label Jun 23, 2025
@robodoo robodoo closed this Jun 23, 2025
@fw-bot fw-bot deleted the master-gauge-chart-animation-adrm branch June 30, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants