[IMP] Clipboard: support images in the clipboard #5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of the cross-browser clipboard relies heavily on an API that is currently only available on Chromium based browsers (see [table](https://developer.mozilla.org/en-US/docs/Web/API/Clipboard_API#api.clipboarditem)). There is currently no definitive announce that the feature will be adopted by other browsers (namely FF and Safari) and since the feature is still marked as experimental, it'd be better to rely ona more generic approach. This revision changes the flow to rely entirely on the `text/html` mimetype as it is supported by all modern browsers. Task: 4241877
This commit adds the support of images in the clipboard. Namely, - Pasting an image from the OS clipboard will automatically upload it to the filestore and dispatch a CREATE_IMAGE accordingly. - Copying a chart or an image from the spreadsheet will add it to the oOS clipboard. It can then be pasted somewhere else, like a discuss app, a text editor maybe?. TODO - support multi type of images (not just png) It technically works because we never check agains the actual type of the file we upload but it's wrong. Maybe use a generic `image/*` mimetype instead of using png. We still need to purge out dangerous mimetypes like image/svg(+xml) - Currently uploads the image from the clipboard THEN only checks if the we are copy pasting from the same spreadsheet clipboard (potential useless upload) - Not supported by some apps like Office 365 online (word & powerpoint tested). Supposedly because our clipboard has some text/* types along the image/* so it ignores the later. for a fully integrated feature, we should probably decorrelate it from the standard copy paste and make a menu "copy image to os clipboard" ? tbd -works on discord at least - No test whatsoever
|
|
rrahir
changed the title
rrahir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This commit adds the support of images in the clipboard. Namely,
the filestore and dispatch a CREATE_IMAGE accordingly.
oOS clipboard. It can then be pasted somewhere else, like a discuss
app, a text editor maybe?.
TODO
because we never check agains the actual type of the file we upload
but it's wrong. Maybe use a generic
image/*mimetype instead of usingpng. We still need to purge out dangerous mimetypes like image/svg(+xml)
we are copy pasting from the same spreadsheet clipboard (potential
useless upload)
clipboard has some text/* types along the image/* so it ignores the
later. for a fully integrated feature, we should probably decorrelate it
from the standard copy paste and make a menu "copy image to os
clipboard" ? tbd
Task: 4241877
review checklist