[FIX] CoreViewPlugin: Remove access to dispatch #5070
Conversation
The CoreView plugins have a local state that is directly derived from the core data. As such, they should not have any impact on plugins other than themselves, especially not on core plugins. This revision removes the dispatch fro the core view plugins altogether as they don't and should not dispatch anything. Task: 4241403
|
|
See #5070 - CoreView plugins replay remote revisions and should not take the risk to dispatch during the replay. The code that was assigning arbitrary default values to the cells of a boolean datavalidation has been moved to a UI feature plugin, hence avoiding the problem raised in PR #5070. Task: 4241141
There was a problem hiding this comment.
That seems like a breaking change so I would do it in master.
Wouldn't it cause problem with pivots/data source ? They need to dispatch EVALUATE_ALL_CELLS and aren't they coreView plugins? And in general removing the dispatch from the CoreView plugin sounds good in paper, but I think there might be relevant use case where a core_view would want to diapatch an UI command.
| @@ -14,6 +14,11 @@ import { | |||
| import { BasePlugin } from "./plugins/base_plugin"; | |||
| import { RangeAdapter } from "./plugins/core/range"; | |||
| import { CorePlugin, CorePluginConfig, CorePluginConstructor } from "./plugins/core_plugin"; | |||
| import { | |||
There was a problem hiding this comment.
typo in commit msg dispatch fro the core view
See #5070 - CoreView plugins replay remote revisions and should not take the risk to dispatch during the replay. The code that was assigning arbitrary default values to the cells of a boolean datavalidation has been moved to a UI feature plugin, hence avoiding the problem raised in PR #5070. Task: 4241141
See #5070 - CoreView plugins replay remote revisions and should not take the risk to dispatch during the replay. The code that was assigning arbitrary default values to the cells of a boolean datavalidation has been moved to a UI feature plugin, hence avoiding the problem raised in PR #5070. Task: 4241141
It's already used in bad conditions, so removing it and fixing whatever uses it seems like a good approach - of course assuming no one is relying on this outside of Odoo. I however proposed #5068 which fixed without "breaking".
the datasource-related plugins don't dispatch anything, it's the datasource itself that sends a message to the their bus which in turn dispatches a global evaluation. |
The CoreView plugins have a local state that is directly derived from the core data. As such, they should not have any impact on plugins other than themselves, especially not on core plugins.
This revision removes the dispatch fro the core view plugins altogether as they don't and should not dispatch anything.
Task: 4241403
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist