Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] cf: apply panel update immediately #5050

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hokolomopo
Copy link
Contributor

Description

The previous workflow of the CF side panel was to edit the conditional format, then click on save to confirm. This wasn't the greatest, as it meant that you wouldn't see the result of your changes until you saved. And if you didn't like the change, you then needed to re-click on the CF to re-open its editor, and do the changes.

With this commit, the CF side panel now updates immediately when you change a value. This also mean that a new CF is created immediately when you click on the "Add" button. The changes made can be discarded by clicking on the "Cancel" button.

Task: 3720877

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

The previous workflow of the CF side panel was to edit the conditional
format, then click on save to confirm. This wasn't the greatest, as it
meant that you wouldn't see the result of your changes until you saved.
And if you didn't like the change, you then needed to re-click on the
CF to re-open its editor, and do the changes.

With this commit, the CF side panel now updates immediately when you
change a value. This also mean that a new CF is created immediately
when you click on the "Add" button. The changes made can be discarded
by clicking on the "Cancel" button.

Task: 3720877
@robodoo
Copy link
Collaborator

robodoo commented Oct 1, 2024

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants