Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] translation #1462

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jun 24, 2022

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #1444

@robodoo
Copy link
Collaborator

robodoo commented Jun 24, 2022

@fw-bot fw-bot mentioned this pull request Jun 24, 2022
14 tasks
@fw-bot
Copy link
Collaborator Author

fw-bot commented Jun 24, 2022

Ping @LucasLefevre, @pro-odoo cherrypicking of pull request #1444 failed.

stderr:

09:12:25.325009 git.c:344               trace: built-in: git cherry-pick 83222e4224f3b821b2959f8d293725b5677f31ae
error: could not apply 83222e42... [FIX] translations: top bar terms
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

There's an issue in odoo when extracing translatable source terms
from the bundled library file `o_spreadsheet.js`. Some terms are not
extracted.

Babel doesn't correctly tokenize the regex /"/
As a result, all following tokens are fucked up and source terms are no longer
exported after this point.

It seems to be known that babel js lexer isn't perfect.
python-babel/babel#467
python-babel/babel#616
python-babel/babel#640
python-babel/babel#791
@LucasLefevre LucasLefevre force-pushed the saas-15.2-15.0-fix-top-translation-lul-SJ6l-fw branch from 7c4a74f to 877036a Compare June 24, 2022 08:19
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Jun 24, 2022
There's an issue in odoo when extracing translatable source terms
from the bundled library file `o_spreadsheet.js`. Some terms are not
extracted.

Babel doesn't correctly tokenize the regex /"/
As a result, all following tokens are fucked up and source terms are no longer
exported after this point.

It seems to be known that babel js lexer isn't perfect.
python-babel/babel#467
python-babel/babel#616
python-babel/babel#640
python-babel/babel#791

closes #1462

Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Jun 24, 2022
@robodoo robodoo temporarily deployed to merge June 24, 2022 08:27 Inactive
@fw-bot fw-bot deleted the saas-15.2-15.0-fix-top-translation-lul-SJ6l-fw branch July 8, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants