Skip to content

[ADD] barcode: serial numbers and lots #13363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

slinkous
Copy link
Contributor

  • Coverage for printing and managing barcoders for product serial numbers and lot numbers

@robodoo
Copy link
Collaborator

robodoo commented May 14, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team May 14, 2025 01:27
@slinkous slinkous requested review from Felicious and removed request for a team May 14, 2025 01:27
@slinkous slinkous self-assigned this May 14, 2025
@slinkous slinkous added the 5 label May 14, 2025
Copy link
Contributor Author

@slinkous slinkous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Felicious this is going to fail CI checks because it's not in the tree, but both my current PR's will go to the same place, so I just need to figure out which one of them gets approved first.

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work with this doc, @slinkous!

It's a very comprehensive doc that covers a variety of use cases and considers many tedious tasks a warehouse user might face, including getting blocked when a shipping label is damaged during transit! That's something I would've never thought of! I can tell you did a lot of research from the master class and watching BE's OXP videos from the previous 2-3 years 😊

I just had some minor nitpicks on wording in this review, and it's ready to go to the next stage after looking through them!

In the case where there are merge conflicts (one will occur in setup.rst), we write in the PR description which one is meant to be merged first. After we merge the first PR, we'll rebase the second PR, resolve the merge conflicts, push the second PR back up, wait for the tests to finish, then merge the second!

After addressing my comments, let's just add the serial_numbers_lots.rst file to setup.rst, so the checks pass for the next reviewer (:

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @slinkous ! Due to the changes to final review, I'd like to take a quick review on this PR after you address my comments, then we'll pass it to sam for technical review (: sound good? :D

Copy link
Contributor Author

@slinkous slinkous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there a particular reason why the instructions below are about enabling mandatory scan, but the image has optional scan highlighted? For consistency, it might be better for the image to match the instructions and the heading of the section

The instructions are about selecting the appropriate setting, it's just that the UI calls this Mandatory Scan. Renaming section to clairfy.

Copy link
Contributor Author

@slinkous slinkous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there a particular reason why the instructions below are about enabling mandatory scan, but the image has optional scan highlighted? For consistency, it might be better for the image to match the instructions and the heading of the section

The instructions are about selecting the appropriate setting, it's just that the UI calls this Mandatory Scan. Renaming section to clairfy.

@slinkous slinkous force-pushed the 18.0-barcode-serials-lots-stul branch 3 times, most recently from 6aa08e9 to 9187b25 Compare May 16, 2025 18:07
@slinkous slinkous requested a review from Felicious May 16, 2025 18:57
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM @slinkous !

There's only an extra blank link so moving this onto you, @samueljlieber !

Copy link
Contributor Author

@slinkous slinkous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for TR, @samueljlieber tyty

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @slinkous! Awesome work on this doc, it is a great addition to this scope! I like how you structured the information– it is a nice read :)

Approving with a couple comments on the images, please address before merge. Thank you!
.....
@robodoo delegate=slinkous

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to lowercase, could even remove since the written instruction is sufficent :)

- serial_numbers_lots/enable-GS1-barcodes.png
+ serial_numbers_lots/enable-gs1-barcodes.png

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this image (content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots/disable-serials-lots-for-op.png)

@slinkous slinkous force-pushed the 18.0-barcode-serials-lots-stul branch from 9187b25 to 5a334bc Compare May 20, 2025 22:45
Co-authored-by: Felicious <feku@odoo.com>

Rename/remove images
@slinkous slinkous force-pushed the 18.0-barcode-serials-lots-stul branch from 5a334bc to 89675ae Compare May 20, 2025 22:48
@slinkous
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants