-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[ADD] barcode: serial numbers and lots #13363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
slinkous
commented
May 14, 2025
- Coverage for printing and managing barcoders for product serial numbers and lot numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Felicious this is going to fail CI checks because it's not in the tree, but both my current PR's will go to the same place, so I just need to figure out which one of them gets approved first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work with this doc, @slinkous!
It's a very comprehensive doc that covers a variety of use cases and considers many tedious tasks a warehouse user might face, including getting blocked when a shipping label is damaged during transit! That's something I would've never thought of! I can tell you did a lot of research from the master class and watching BE's OXP videos from the previous 2-3 years 😊
I just had some minor nitpicks on wording in this review, and it's ready to go to the next stage after looking through them!
In the case where there are merge conflicts (one will occur in setup.rst
), we write in the PR description which one is meant to be merged first. After we merge the first PR, we'll rebase the second PR, resolve the merge conflicts, push the second PR back up, wait for the tests to finish, then merge the second!
After addressing my comments, let's just add the serial_numbers_lots.rst
file to setup.rst
, so the checks pass for the next reviewer (:
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @slinkous ! Due to the changes to final review, I'd like to take a quick review on this PR after you address my comments, then we'll pass it to sam for technical review (: sound good? :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was there a particular reason why the instructions below are about enabling mandatory scan, but the image has optional scan highlighted? For consistency, it might be better for the image to match the instructions and the heading of the section
The instructions are about selecting the appropriate setting, it's just that the UI calls this Mandatory Scan. Renaming section to clairfy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was there a particular reason why the instructions below are about enabling mandatory scan, but the image has optional scan highlighted? For consistency, it might be better for the image to match the instructions and the heading of the section
The instructions are about selecting the appropriate setting, it's just that the UI calls this Mandatory Scan. Renaming section to clairfy.
6aa08e9
to
9187b25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM @slinkous !
There's only an extra blank link so moving this onto you, @samueljlieber !
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for TR, @samueljlieber tyty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to lowercase, could even remove since the written instruction is sufficent :)
- serial_numbers_lots/enable-GS1-barcodes.png
+ serial_numbers_lots/enable-gs1-barcodes.png
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this image (content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots/disable-serials-lots-for-op.png
)
9187b25
to
5a334bc
Compare
Co-authored-by: Felicious <feku@odoo.com> Rename/remove images
5a334bc
to
89675ae
Compare
@robodoo r+ |