[IMP] accounting/l10n_ec: electronic delivery guide Ecuador #12556
Conversation
|
|
|
Hello!! @samueljlieber |
samueljlieber
force-pushed
the
danielacanez-patch-4
branch
from
1cbf7ac to
2fdd4c4
Compare
samueljlieber
changed the title
There was a problem hiding this comment.
Hi @danielacanez! Thank you for your work on this PR! I made a commit to add the images and update the RST for final review. Approving! :)
There was a problem hiding this comment.
Hi @danielacanez and @samueljlieber! 🙂
Thank you for your work on this page! I added a few comments and suggestions. Let me know if you have any questions! Thanks
Also, we are currently testing new guidelines/templates for loc documentation pages. The Ecuadorian page would be a great opportunity for me to apply those principles. I'll make some structural adjustments to it, and since the new Credit notes and refunds page has been updated, I could also only keep the Ecuadorian-specific info to avoid duplication.
If that suits you, I'll update the page and force-push the changes. Then, I'll ask you to check if I didn't miss anything.
Does that work for you?
Thank you!
| .. image:: ecuador/l10n-ec-carrier-contact.png | ||
| :alt: Configuration of a carrier contact. |
There was a problem hiding this comment.
I don't think the image adds any information in this case. The text is pretty clear.
| .. image:: ecuador/l10n-ec-carrier-contact.png | |
| :alt: Configuration of a carrier contact. |
| .. image:: ecuador/l10n-ec-delivery-guide-settings.png | ||
| :alt: Delivery Guide Settings. |
There was a problem hiding this comment.
I think the image is unnecessary because the explanation above is comprehensive.
| .. image:: ecuador/l10n-ec-delivery-guide-settings.png | |
| :alt: Delivery Guide Settings. |
| An email can be sent to the contact used in the :guilabel:`Delivery Address` field to receive the | ||
| XML and PDF - this is an optional and manual step; the :guilabel:`Send Email` button needs to be | ||
| clicked. |
There was a problem hiding this comment.
When I tested it, I couldn't find the Send Email button. Maybe it would be nice to have more instructions to be as precise as possible. What do you think?
There was a problem hiding this comment.
Hii! @afma-odoo
We have the button, could you confirm plss
There was a problem hiding this comment.
Hi @danielacanez! Ok, great! Sorry, I probably missed something in the configuration :) If you have it, that's perfect.
afma-odoo
force-pushed
the
danielacanez-patch-4
branch
from
2fdd4c4 to
5319065
Compare
|
Hi @danielacanez and @samueljlieber! Since the "Electronic delivery guide" section was no longer in the same place in the document, I made the changes I suggested to avoid confusion. Don't hesitate to let me know if you have any comments. I just kept 3 suggestions for that part. Please take a look at it and let me know if you have any questions. Thank you for being so patient; I appreciate it very much! |
|
Hi team! @samueljlieber @afma-odoo |
|
Hi @danielacanez! |
|
Hello @afma-odoo, everything looks fine on my end! |
|
@danielacanez Great! |
Hello!! Hope you're doing great! do we have a new status for this pull request? Thanks! |
|
Hello @danielacanez! Hope you're doing great too |
|
Hey @danielacanez I see you closed this PR, was this intended? (sorry I know I have a bit of backlog and haven't been able to review this PR until now) |
Hello! no this was not intentional! do we have any update? |
ADD section
Content-based on V18
Images : https://drive.google.com/drive/u/0/folders/1mVGcrzyb0t0ny7m0cuwSOQsvdD4G9z3o