Skip to content

[FIX] ecommerce: clarify step for email queue optimization #12413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 13, 2025

This commit rephrases slightly the step to enable the cron because it should already be enabled, unless the user disabled it manually. Indeed, the cron is created disabled but automatically enabled when toggling the sale.async_emails system parameter.

task-3872792

Forward-Port-Of: #12389

@robodoo
Copy link
Collaborator

robodoo commented Mar 13, 2025

Pull request status dashboard

This commit rephrases slightly the step to enable the cron because it
should already be enabled, unless the user disabled it manually. Indeed,
the cron is created disabled but automatically enabled when toggling the
`sale.async_emails` system parameter.

task-3872792

X-original-commit: c7843cb
@AntoineVDV AntoineVDV force-pushed the master-17.0-ecom-flash-sales-param-bis-anv-422541-fw branch from 130b9b3 to 5c96d4f Compare March 13, 2025 12:05
@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 13, 2025

@AntoineVDV @auva-odoo this PR was modified / updated and has become a normal PR. It must be merged directly.

@AntoineVDV AntoineVDV changed the title [FW][FIX] ecommerce: require module install for email queue optimization [FIX] ecommerce: clarify step for email queue optimization Mar 13, 2025
@AntoineVDV
Copy link
Collaborator

@robodoo r+

@C3POdoo C3POdoo requested a review from a team March 13, 2025 12:08
robodoo pushed a commit that referenced this pull request Mar 13, 2025
This commit rephrases slightly the step to enable the cron because it
should already be enabled, unless the user disabled it manually. Indeed,
the cron is created disabled but automatically enabled when toggling the
`sale.async_emails` system parameter.

task-3872792

closes #12413

X-original-commit: c7843cb
Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@robodoo robodoo added the 18.3 label Mar 13, 2025
@robodoo robodoo closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants