-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to allow display of the flag in the form widget #152
Conversation
Hello @DesLynx , thank you very much for this contribution! It looks interesting. However please share with us why, how, and also some screen of how it looks. (any details will help us decide if yes or no we are going to use it). It also adds a new extension as the requirement... I think mbstring is probably installed everywhere by default, but we should consider this anyway. |
Hi! Note: I removed the requirement for the mbstring extension as Here is a screenshot (in Firefox) for this config: $form = $this->createFormBuilder($obj)
->add('phone', PhoneNumberType::class, [
'label' => 'Phone number',
'required' => true,
'widget' => PhoneNumberType::WIDGET_COUNTRY_CHOICE,
'country_choices' => [],
'preferred_country_choices' => ['FR', 'CH', 'BE', 'LU'],
'country_display_emoji_flag' => true,
])
->getForm(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great for me! 👌
@DesLynx thanks for the details, however, we need to add the |
Thanks @DesLynx ! |
Hi! I noticed that you haven't created a new tag for the repo since merging the PR. As it adds the info about the new option |
Provides a solution for #105