Fix PhoneNumber constraint default message #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Oct 24, 2022
Nek-
approved these changes
Dec 2, 2022
|
Yes it's nice thank you |
|
The CI failed (https://github.com/odolbeau/phone-number-bundle/actions/runs/3603679058/jobs/6072168474). Can you also adapt the tests so that it comes back |
Merged
|
@maxhelias fixed in #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using validation by @Attribute, when it fails, the default message when there is more than one type is:
phone-number-bundle/src/Validator/Constraints/PhoneNumber.php
Line 115 in 40e330c
Which does not have a translated message.
As I see, the default message should be "This value is not a valid phone number.".