Fix fontstash crash with .TTC files #5773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st font correctly. The old setup didn't work with TTC files that contain multiple fonts.
Kelimion
reviewed
Oct 8, 2025
vendor/fontstash/fontstash.odin
Outdated
| stbtt.InitFont(&res.info, &res.loadedData[0], 0) | ||
| // Get offset of first font (if the font is a TTC then it can contain multiple fonts) | ||
| // Note: There is currently no support for specifying any other font than first one. | ||
| font_offset := stbtt.GetFontOffsetForIndex(raw_data(res.loadedData), 0) |
There was a problem hiding this comment.
Instead of hardcoding, I'd give AddFontMem and AddFontFile a default ttc_index := 0 param, with a little comment that that param determines which ttf file in a .ttc to load, defaulting to the first (or only for .ttf).
There was a problem hiding this comment.
Thanks. Reasonable. I'll fix it tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for fontstash crash because it didn't fetch the offset of the first font correctly. The old setup didn't work with TTC files that contain multiple fonts.