Fix issue 5506 and add check_expr_as_value #5511
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paul-Andre
force-pushed
the
fix-issue-5506
branch
from
b3dfbb4 to
c000ff5
Compare
gingerBill
requested changes
Jul 29, 2025
src/check_expr.cpp
Outdated
Comment on lines
8226
to
8265
| case Addressing_Type: { | ||
| ERROR_BLOCK(); | ||
| gbString expr_str = expr_to_string(o->expr); | ||
|
|
||
| error(o->expr, | ||
| "Cannot use type '%s' as a runtime value", | ||
| expr_str); | ||
|
|
||
| error_line("\tUse typeid_of to convert it to a typeid that can be used at runtime\n"); | ||
|
|
||
| gb_string_free(expr_str); | ||
| o->mode = Addressing_Invalid; | ||
| break; | ||
| } | ||
| case Addressing_Builtin: { | ||
| ERROR_BLOCK(); | ||
| gbString expr_str = expr_to_string(o->expr); | ||
|
|
||
| error(o->expr, | ||
| "Cannot use built-in procedure '%s' as a runtime value", | ||
| expr_str); | ||
|
|
||
| error_line("\tBuilt-in procedures are implemented by the compiler and might not be actually instantiated procedures\n"); | ||
|
|
||
| gb_string_free(expr_str); | ||
| o->mode = Addressing_Invalid; | ||
| break; | ||
| } | ||
| case Addressing_ProcGroup : { | ||
| ERROR_BLOCK(); | ||
| gbString expr_str = expr_to_string(o->expr); | ||
|
|
||
| error(o->expr, | ||
| "Cannot use overloaded procedure '%s' as a runtime value", | ||
| expr_str); | ||
|
|
||
| gb_string_free(expr_str); | ||
| o->mode = Addressing_Invalid; | ||
| break; | ||
| } |
There was a problem hiding this comment.
Please follow the style of the rest of the code base and don't indent cases
src/check_expr.cpp
Outdated
| o->mode = Addressing_Invalid; | ||
| break; | ||
| } | ||
| case Addressing_ProcGroup : { |
src/check_expr.cpp
Outdated
| "Cannot use type '%s' as a runtime value", | ||
| expr_str); | ||
|
|
||
| error_line("\tUse typeid_of to convert it to a typeid that can be used at runtime\n"); |
There was a problem hiding this comment.
That phrasing is a bit confusing. Prefer:
error_line("\tuse 'typeid_of' to convert a type to a runtime 'typeid' value\n");
src/check_expr.cpp
Outdated
| gbString expr_str = expr_to_string(o->expr); | ||
|
|
||
| error(o->expr, | ||
| "Cannot use overloaded procedure '%s' as a runtime value", |
There was a problem hiding this comment.
Well overloaded procedures can be used if the type can be inferred correctly.
Paul-Andre
force-pushed
the
fix-issue-5506
branch
from
c000ff5 to
a1027c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix was basically making sure we additionally check that the operands of a ternary_if are not Builtin and not ProcGroup
The new function
check_expr_as_valueis based oncheck_expr_with_type_hintand could replace it, and calls tocheck_expr_or_typein certain places, in a future refactoring.#5506