Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static GLFW bindings for Linux #4302

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

Pariatech
Copy link
Contributor

I static link GLFW for my game but I can't do that with the current bindings for linux.
I kept the default as true for shared linking for linux to not break anyone else.

@gingerBill
Copy link
Member

And have these been built to work on all distros of Linux? Because if they haven't, I will close this PR.

@gingerBill
Copy link
Member

I know they are the ones that are in there already, but they might not be linked for a good reason.

@flysand7
Copy link
Contributor

And have these been built to work on all distros of Linux? Because if they haven't, I will close this PR.

He didn't push any binaries, from what I can see

@gingerBill
Copy link
Member

@flysand7

I know they are the ones that are in there already, but they might not be linked for a good reason.

@Pariatech
Copy link
Contributor Author

Pariatech commented Sep 25, 2024

And have these been built to work on all distros of Linux? Because if they haven't, I will close this PR.

That's why I didn't push any binary, just a way to static link a binary if so desired. And without breaking any other linux Odin user if they want use the GLFW bindings without building their own binary by making GLFW_SHARED to true by default for them.

@Pariatech
Copy link
Contributor Author

Also I didn't want to be the guy that just put in a binary with a "trust me bro, it works ;-)". Meanwhile the binary that I generate for myself via a debian:latest docker seems to work for the people that tested my game in linux (arch, mint, debian). But even then I can't 100% guarantee that it will work on everyone linux box, especially if the user is running an old kernel / libc system.

@laytan laytan merged commit 085b725 into odin-lang:master Sep 29, 2024
7 checks passed
@Pariatech Pariatech deleted the enable_static_glfw_linux branch September 29, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants