Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for bit_set[$T] proc params always being generated as i8 #3842

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Fix for bit_set[$T] proc params always being generated as i8 #3842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/check_expr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1435,6 +1435,16 @@ gb_internal bool is_polymorphic_type_assignable(CheckerContext *c, Type *poly, T
if (!is_polymorphic_type_assignable(c, poly->BitSet.elem, source->BitSet.elem, true, modify_type)) {
return false;
}

// For generic types like bit_set[$T] the upper and lower of the poly type will be zeroes since
// it could not figure that stuff out when the poly type was created.
if (poly->BitSet.upper == 0 && modify_type) {
poly->BitSet.upper = source->BitSet.upper;
}
if (poly->BitSet.lower == 0 && modify_type) {
poly->BitSet.lower = source->BitSet.lower;
}

if (poly->BitSet.underlying == nullptr) {
if (modify_type) {
poly->BitSet.underlying = source->BitSet.underlying;
Expand Down