Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cue slices cause file corruption on quicksaves #30

Closed
tmfset opened this issue May 17, 2021 · 1 comment
Closed

Cue slices cause file corruption on quicksaves #30

tmfset opened this issue May 17, 2021 · 1 comment

Comments

@tmfset
Copy link
Contributor

tmfset commented May 17, 2021

https://forum.orthogonaldevices.com/t/v0-6-x-release-candidate-packages-and-mods/5246/210

Reproduced with https://freesound.org/people/meyweg/sounds/569604/

Corrupted file seems to be entirely replaced, possibly with the slices file (went from 15MB down to 139B):

> xxd ~/.od/front/ER-301/569604__meyweg__vocal-chords-morphagene-reel.wav
00000000: badc cdab 0700 0000 536c 6963 6573 0000  ........Slices..
00000010: 0000 0000 0000 0007 0000 0053 6c03 0000  ...........Sl...
00000020: 0000 0000 0000 0000 0080 3f5b 1107 0000  ..........?[....
00000030: 0000 0000 0000 0000 0080 3f16 ce0a 0000  ..........?.....
00000040: 0000 0000 0000 0000 0080 3fb9 860e 0000  ..........?.....
00000050: 0000 0000 0000 0000 0080 3f57 4a12 0000  ..........?WJ...
00000060: 0000 0000 0000 0000 0080 3f0b 0416 0000  ..........?.....
00000070: 0000 0000 0000 0000 0080 3f60 bd19 0000  ..........?`....
00000080: 0000 0000 0000 0000 0080 3f              ..........?

Failure trace:

stack traceback:
	[C]: in for iterator 'for iterator'
	...rc/er-301-custom-units/er-301/xroot/Sample/Pool/init.lua:573: in function 'Sample.Pool.clear'
	...01-custom-units/er-301/xroot/Persist/QuickSavePreset.lua:92: in function 'Persist.QuickSavePreset.apply'
	...et/src/er-301-custom-units/er-301/xroot/Persist/init.lua:733: in local 'task'
	...et/src/er-301-custom-units/er-301/xroot/Persist/init.lua:120: in upvalue 'confirmFirmwareVersionAndExecute'
	...et/src/er-301-custom-units/er-301/xroot/Persist/init.lua:740: in function 'Persist.quickLoad'
	.../er-301-custom-units/er-301/xroot/Persist/QuickSaver.lua:304: in function 'Persist.QuickSaver.load'
	(...tail calls...)
	.../er-301-custom-units/er-301/xroot/Persist/QuickSaver.lua:250: in local 'handler'
	...set/src/er-301-custom-units/er-301/xroot/Base/Widget.lua:164: in function 'Persist.QuickSaver.sendUpHelper'
	...set/src/er-301-custom-units/er-301/xroot/Base/Widget.lua:151: in function 'Persist.QuickSaver.sendUp'
	...et/src/er-301-custom-units/er-301/xroot/Base/Context.lua:226: in function 'Base.Context.notify'
	...set/src/er-301-custom-units/er-301/xroot/Application.lua:168: in function 'Application.notify'
	...set/src/er-301-custom-units/er-301/xroot/Application.lua:320: in function 'Application.defaultDispatcher'
	...set/src/er-301-custom-units/er-301/xroot/Application.lua:495: in function 'Application.loop'
	...iset/src/er-301-custom-units/er-301/xroot/boot/start.lua:54: in function <...iset/src/er-301-custom-units/er-301/xroot/boot/start.lua:46>
	[C]: in function 'xpcall'
	...iset/src/er-301-custom-units/er-301/xroot/boot/start.lua:65: in main chunk
	[C]: in function 'dofile'
	[string "dofile('/Users/tom.fiset/src/er-301-custom-un..."]:1: in main chunk
@odevices
Copy link
Owner

Ah. I see the problem. For some weird reason I'm caching the load path in Slices.lua and then using it when saving. Working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants