Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please rename drive to something less generic #271

Closed
sbrun opened this issue Jul 4, 2015 · 18 comments
Closed

Please rename drive to something less generic #271

sbrun opened this issue Jul 4, 2015 · 18 comments
Milestone

Comments

@sbrun
Copy link

sbrun commented Jul 4, 2015

Hi,

I'm in the process of packaging drive for debian. As Guillem commented in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=790933#10 the name drive is very generic. It would be better to use another name to avoid conflicts with local commands using such generic names (or with other random software that people install from the net).

I would suggest "google-drive" or "gdrive" or something similar. What do you think ?

Thank you for considering my request.

@odeke-em
Copy link
Owner

odeke-em commented Jul 4, 2015

Hello @sbrun, thank you for reporting this issue and welcome to drive!

In response to your request: I don't think this is an issue because the project has been around for the last two years (however 7 months with my fork) without conflicting with other projects.
A volunteer who packages drive for ArchLinux and Ubuntu (@shaggytwodope) has been able to do this for the last 7 months also without any conflict. Please take a look at https://github.com/odeke-em/drive/blob/master/platform_packages.md and https://github.com/shaggytwodope/drivedebpackage.
Also the publicity of the project is tied to the name drive and even the references already made to it.
Unfortunately, I feel like it is already too late to make a project name change that I personally don't see a reason to.

Please let me know what you think.
Thanks.

@sbrun
Copy link
Author

sbrun commented Jul 4, 2015

Hello,

Thanks for your answer.
There is no conflict for now but it's really generic so I can't tell in
the future. I understand it's quite difficult to change a name after two
years.
There were similar cases in the past in debian and quite often they
preferred to rename the package and the script.
Very generic names are best left for the user (custom scripts, shell
aliases, etc)
I'm not sure that the package will be accepted under the name drive.

Le 04/07/2015 11:21, Emmanuel Odeke a écrit :

Hello @sbrun https://github.com/sbrun, thank you for reporting this
issue and welcome to drive!

In response to your request: I don't think this is an issue because the
project has been around for the last two years (however 7 months with my
fork) without conflicting with other projects.
A volunteer who packages drive for ArchLinux and Ubuntu (@shaggytwodope
https://github.com/shaggytwodope) has been able to do this for the
last 7 months also without any conflict. Please take a look at
https://github.com/odeke-em/drive/blob/master/platform_packages.md and
https://github.com/shaggytwodope/drivedebpackage.
Also the publicity of the project is tied to the name |drive| and even
the references already made to it.
Unfortunately, I feel like it is already too late to make a project name
change that I personally don't see a reason to.

Please let me know what you think.
Thanks.


Reply to this email directly or view it on GitHub
#271 (comment).

@fommil
Copy link

fommil commented Jul 9, 2015

@rhertzog fyi

@rhertzog
Copy link

FWIW, the corresponding request to add a package generated quite some discussion about the name. You can check it out here: https://lists.debian.org/debian-devel/2015/07/threads.html#00023

We were going to rename the package to google-drive before integrating it in Debian anyway.

But we will stop pursuing this "Intent to package" as it is much more work than anticipated.

@professorjamesmoriarty
Copy link

@odeke-em I think this should be closed as the topic is sorta moved on to issue #277

@odeke-em
Copy link
Owner

Thanks for the heads up @shaggytwodope. However, I think I'll let @sbrun make that decision on how to close it since her issue came first and spawned the entire Debian thread.

@rhertzog
Copy link

@odeke-em Given the discussion in the Debian thread, if I have to sponsor someone to add drive to Debian I would ask him to rename the package and the binary to something less generic. Given that you did not seem to agree, we intended to pick a name ourselves: "google-drive".

Now it's up to you to see whether you want to rename your software or not. If not, close this ticket. If you need more time to think about it, leave it open.

@odeke-em
Copy link
Owner

@rhertzog gotcha. Am still hesitant on renaming it but feel free to rename it on the packaging end. Thing is the manifesto is to be able to add other backends in the future: ownCloud, s3, Dropbox, Azure etc and this is alluded to in the README. Switching the entire project's name to google-drive is putting the entire project in a box. It would be easier to spawn sub-projects e.g google-drive or s3-drive later on since all that will be required will be a sub directory.

@odeke-em
Copy link
Owner

Btw Go binaries get their name from the directory they are stored in, so it wouldn't require naming the entire project, just a sect of it and throwing in a directory. Let me push up a PR that will enable this and the issue should be resolved. I think the original issue title should have been change the binary name :)

@sbrun
Copy link
Author

sbrun commented Jul 10, 2015

Hello @odeke-em
I think it's better to keep this issue opened until you make your decision about the name.
Thanks

@professorjamesmoriarty
Copy link

Reading the mailinglist over at debian I saw the idea of calling it odeke-drive. I kinda dig that... even tho @odeke-em is a terrible name (j/k mate :-p) go-drive could also be an idea for the debian pacakge. But I'am terrible with names, my first dog was named Doggy...

@odeke-em
Copy link
Owner

@shaggytwodope hahaha.
Hey y'all, please see PR #280 or get the latest from master.
Now you'll be able to say

$ go get -u github.com/odeke-em/drive/google-drive
$ # OR
$ go get -u github.com/odeke-em/drive/drive-gen && drive-gen google-drive # To bundle debug info

And now the binary should be google-drive.

Please let me know if that solves your problem.

@odeke-em odeke-em added this to the v0.2.6 milestone Jul 10, 2015
@odeke-em
Copy link
Owner

Am off to bed for now, but I'll be back up shortly.

@odeke-em
Copy link
Owner

Ping in case anyone has any thoughts.

@odeke-em
Copy link
Owner

Just changed the alternate binary to drive-google to match the suffixing that had earlier been mentioned, and to avoid using the Google Drive trademark without their consent. Please get the latest from master.

@odeke-em
Copy link
Owner

Closing this issue since you can now generate a binary called drive-google. Thank you everyone for the thoughts and @sbrun for raising it.

@Vamoss
Copy link

Vamoss commented Oct 24, 2017

Hi @odeke-em , sorry for reviving this topic, I run successfully the command:
go get -u github.com/odeke-em/drive/google-drive

But drive-google is not being recognized as a command. This still works for Debian?

Cheers!

@thomasweng15
Copy link

@Vamoss check if your environment variables are set correctly, as mentioned in the install docs:
export GOPATH=$HOME/gopath
export PATH=$GOPATH:$GOPATH/bin:$PATH

Setting these fixed the issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants