Merge pull request #74 from odeialba/SV-59

SV-59 Fix CI warnings
odeialba · Oct 11, 2024 · 645cd0e · 645cd0e
2 parents c31b978 + ee8d0e6
commit 645cd0e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/mobile/js/init.js b/mobile/js/init.js
@@ -62,6 +62,7 @@ class AddonModSortVotingProvider {
                 votes: votes
             };
 
+            /* eslint-disable promise/no-nesting */
             return site.write('mod_sortvoting_save_vote', params).then((response) => {
                 if (!response || response.success === false) {
                     // TODO: Add warnings array to save_vote returns.
@@ -71,7 +72,10 @@ class AddonModSortVotingProvider {
 
                     throw error;
                 }
+
+                return;
             });
+            /* eslint-enable promise/no-nesting */
         });
     }
 
@@ -83,4 +87,5 @@ const result = {
     sortVotingProvider: sortVotingProvider,
 };
 
+// eslint-disable-next-line no-unused-expressions
 result;
diff --git a/mobile/js/mobile_sortvoting.js b/mobile/js/mobile_sortvoting.js
@@ -21,6 +21,7 @@
  */
 this.submitResponses = () => {
     let promise;
+    // eslint-disable-next-line promise/no-native
     promise = Promise.resolve();
     promise.then(() => {
         // Show loading modal.
@@ -39,6 +40,7 @@ this.submitResponses = () => {
             });
         });
 
+        /* eslint-disable promise/no-nesting */
         return this.sortVotingProvider.submitResponses(this.module.instance, votes).then(() => {
             // Responses have been sent to server or stored to be sent later.
             this.CoreDomUtilsProvider.showToast(this.TranslateService.instant('plugin.mod_sortvoting.votesuccess'));
@@ -53,6 +55,7 @@ this.submitResponses = () => {
         }).finally(() => {
             modal.dismiss();
         });
+        /* eslint-enable promise/no-nesting */
     }).catch(() => {
         // User cancelled, ignore.
     });
@@ -64,7 +67,7 @@ this.moveUp = (id) => {
     // Change value of the input elements.
     var prevId = 0;
     var canMove = true;
-    options.forEach(function (option, index) {
+    options.forEach(function(option, index) {
         if (option.getAttribute('data-optionid') == id) {
             if (parseInt(option.value) == option.getAttribute('min')) {
                 canMove = false;
@@ -93,7 +96,7 @@ this.moveDown = (id) => {
     // Change value of the input elements.
     var nextId = 0;
     var canMove = true;
-    options.forEach(function (option, index) {
+    options.forEach(function(option, index) {
         if (option.getAttribute('data-optionid') == id) {
             if (parseInt(option.value) == option.getAttribute('max')) {
                 canMove = false;

diff --git a/tests/generator/lib.php b/tests/generator/lib.php
@@ -30,7 +30,7 @@ class mod_sortvoting_generator extends testing_module_generator {
      * @param array|null $options
      * @return stdClass
      */
-    public function create_instance($record = null, array $options = null) {
+    public function create_instance($record = null, ?array $options = null) {
         $record = (object)(array)$record;
 
         if (!isset($record->timemodified)) {