BREAKING CHANGE: Migrate to Django 5.1+ STORAGES setting #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates django-gcp to use Django 5.1's STORAGES setting, dropping support for Django <5.1 and the deprecated DEFAULT_FILE_STORAGE and STATICFILES_STORAGE settings. Changes: - Update minimum Django version to >=5.1,<6.0 - Refactor StorageSettings to read from STORAGES dict instead of GCP_STORAGE_MEDIA/STATIC/EXTRA_STORES settings - Update all test cases to use new STORAGES format - Update storage.rst documentation with new examples and migration guide - Add breaking changes notice to version_history.rst - Update docstrings in storage classes to reference STORAGES setting Migration required: Users must update their Django settings from the old GCP_STORAGE_* format to the new STORAGES dict format. See documentation for detailed migration instructions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove unnecessary mapping between Django storage aliases and internal store keys. Use Django's standard aliases throughout (default, staticfiles). Changes: - Remove media/static mapping from StorageSettings._stores_settings - Update GoogleCloudMediaStorage to use store_key="default" - Update GoogleCloudStaticStorage to use store_key="staticfiles" - Update all BlobField examples to use store_key="default" - Add base_url to all STORAGES OPTIONS examples (prevents URL/bucket drift) - Update migration guide to document BlobField store_key changes - Add note about base_url being recommended over MEDIA_URL/STATIC_URL Breaking changes: - BlobField store_key must be updated: - store_key="media" → store_key="default" - store_key="static" → store_key="staticfiles" - Extra store keys now match STORAGES dict keys directly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates django-gcp to use Django 5.1's STORAGES setting, dropping support for Django <5.1 and the deprecated DEFAULT_FILE_STORAGE and STATICFILES_STORAGE settings.
Changes:
Migration required: Users must update their Django settings from the old GCP_STORAGE_* format to the new STORAGES dict format. See documentation for detailed migration instructions.
🤖 Generated with Claude Code
Contents (#93)
Refactoring
Other