Skip to content

Commit

Permalink
ENH: Remove filter and suffix options; replace with services namespace
Browse files Browse the repository at this point in the history
  • Loading branch information
cortadocodes committed Apr 8, 2024
1 parent 5053e05 commit 311e8f3
Show file tree
Hide file tree
Showing 4 changed files with 42 additions and 46 deletions.
13 changes: 4 additions & 9 deletions action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,10 @@ inputs:
description: "The service revision tag (e.g. 1.0.7). If this option isn't given, a random 'cool name' tag is generated e.g. 'curious-capybara'."
required: false
default: ""
filter:
description: "An optional filter to apply to the subscription (see https://cloud.google.com/pubsub/docs/subscription-message-filter). If not provided, the default filter is applied. To disable filtering, provide an empty string."
services_namespace:
description: "The services namespace to subscribe to."
required: false
default: 'attributes.sender_type = "PARENT"'
subscription_suffix:
description: "An optional suffix to add to the end of the subscription name. This is useful when needing to create multiple subscriptions for the same topic (subscription names are unique)."
required: false
default: ""
default: 'octue.services'

runs:
using: 'docker'
Expand All @@ -46,5 +42,4 @@ runs:
- ${{ inputs.push_endpoint }}
- ${{ inputs.expiration_time }}
- ${{ inputs.service_revision_tag }}
- ${{ inputs.filter }}
- ${{ inputs.subscription_suffix }}
- ${{ inputs.services_namespace }}
2 changes: 1 addition & 1 deletion create_push_subscription/entrypoint.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/bin/sh -l

octue deploy create-push-subscription $1 $2 $3 $4 --expiration-time=$5 --revision-tag=$6 --filter="$7" --subscription-suffix="$8"
octue deploy create-push-subscription $1 $2 $3 $4 --expiration-time=$5 --revision-tag=$6 --services-namespace=$7
71 changes: 36 additions & 35 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ readme = "README.md"

[tool.poetry.dependencies]
python = "^3.10"
octue = { "git" = "https://github.com/octue/octue-sdk-python", "rev" = "better-support-asynchronous-questions"}
octue = { "git" = "https://github.com/octue/octue-sdk-python", "rev" = "use-single-topic-per-workspace" }

[tool.poetry.group.dev.dependencies]
pre-commit = "^2.20.0"
Expand Down

0 comments on commit 311e8f3

Please sign in to comment.