Skip to content

Commit

Permalink
ENH: Add subscription_suffix input
Browse files Browse the repository at this point in the history
  • Loading branch information
cortadocodes committed Mar 19, 2024
1 parent 6ebcada commit 1011a19
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,6 @@ steps:
push_endpoint: https://example.com/endpoint
expiration_time: 86400 # optional
filter: 'attributes.sender_type = "PARENT"' # optional
subscription_suffix: something-useful # optional

```
5 changes: 5 additions & 0 deletions action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ inputs:
description: "An optional filter to apply to the subscription (see https://cloud.google.com/pubsub/docs/subscription-message-filter). If not provided, the default filter is applied. To disable filtering, provide an empty string."
required: false
default: 'attributes.sender_type = "PARENT"'
subscription_suffix:
description: "An optional suffix to add to the end of the subscription name. This is useful when needing to create multiple subscriptions for the same topic (subscription names are unique)."
required: false
default: ""

runs:
using: 'docker'
Expand All @@ -43,3 +47,4 @@ runs:
- ${{ inputs.expiration_time }}
- ${{ inputs.service_revision_tag }}
- ${{ inputs.filter }}
- ${{ inputs.subscription_suffix }}
2 changes: 1 addition & 1 deletion create_push_subscription/entrypoint.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/bin/sh -l

octue deploy create-push-subscription $1 $2 $3 $4 --expiration-time=$5 --revision-tag=$6 --filter=$7
octue deploy create-push-subscription $1 $2 $3 $4 --expiration-time=$5 --revision-tag=$6 --filter=$7 --subscription-suffix=$8
2 changes: 1 addition & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1011a19

Please sign in to comment.