Use ts imports in src #1144
Use ts imports in src #1144
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
package-lock.json
Outdated
There was a problem hiding this comment.
I don't think this is supposed to be updated here
There was a problem hiding this comment.
Yes, looks strange indeed. I will check it when I am back home. I guess i was using node 18 npm and it removed the integrity and resolved fields
There was a problem hiding this comment.
Seems like it was connected with https://stackoverflow.com/questions/75224019/resolved-and-integrity-go-missing-in-package-lock-json as I had to cleanthe cache to generate a proper package-lock.json. But the change in package-lock.json was not necessary so I reverted it ;)
Splitting up my refactor PR into multiple PRs so that it can be easier reviewed.
This PR changes the imports to .ts files in the src folder.
With this, you can also test the code in deno. Also it seems that --experimental-strip-types can work better with that on node24.