Skip to content

docs: fix assignment in plugin example #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

hopkinsth
Copy link
Contributor

This example in the docs needs to use destructuring assignment to work. I know this code wouldn't actually run as-is but did trip me up in a fury of copy-pasting.

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@wolfy1339 wolfy1339 added Type: Bug Something isn't working as documented Type: Documentation Improvements or additions to documentation labels Jun 10, 2021
@gr2m gr2m merged commit e9d820f into octokit:master Jun 10, 2021
@hopkinsth hopkinsth deleted the docs/fix-plugin-example branch June 10, 2021 19:47
@github-actions
Copy link
Contributor

🎉 This PR is included in version 18.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants