[BUG]: total_count missing from paginated response types

[robertbrignull]

What happened?

In https://github.com/github/vscode-codeql/blob/main/extensions/ql-vscode/src/databases/code-search-api.ts we're using octokit.paginate.iterator(octokit.rest.search.code) and on the response we're checking response.data.total_count. In the upgrade from 21.0.2 to 21.1.0 this field seems to have disappeared. It's still there in the response from GitHub (i.e. making the request with curl) but it gets deleted before it reaches our code.

We're wondering if this change came from #637 but we're not sure and also check if this was an intentional effect or not. Alternatively, is there another recommended way to access the total_count field?

Versions

@octokit/rest v21.1.0

Relevant log output

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[wolfy1339]

That only affects types, the field is still there

[robertbrignull]

Thanks for looking into this!

That only affects types, the field is still there

I agree 👍🏼

I briefly got myself confused because the data field is an array but also has these other fields. This means if you do JSON.stringify then it only shows the array part, but the other fields are there on the javascript object and you can access them directly by name.