Skip to content

[BUG]: Published package still require @octokit/core@5, which breaks peer dependency #622

@siketyan

Description

@siketyan

What happened?

Though

"@octokit/core": ">=6"
specifies @octokit/core@>=6 as peer dependency, the published package still require @octokit/core@5. This breaks peer dependency on our environment.

 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies

.
├ @octokit/rest 21.0.0
├─┬ @octokit/plugin-paginate-rest 11.3.1
│ └── ✕ unmet peer @octokit/core@5: found 6.1.2 in @octokit/rest
└─┬ @octokit/plugin-rest-endpoint-methods 13.2.2
  └── ✕ unmet peer @octokit/core@^5: found 6.1.2 in @octokit/rest
❯ pnpm show @octokit/plugin-paginate-rest@11.3.1

@octokit/plugin-paginate-rest@11.3.1 | MIT | deps: 1 | versions: 109
Octokit plugin to paginate REST API endpoint responses
https://github.com/octokit/plugin-paginate-rest.js#readme

keywords: github, api, sdk, toolkit

dist
.tarball: https://registry.npmjs.org/@octokit/plugin-paginate-rest/-/plugin-paginate-rest-11.3.1.tgz
.shasum: fe92d04b49f134165d6fbb716e765c2f313ad364
.integrity: sha512-ryqobs26cLtM1kQxqeZui4v8FeznirUsksiA+RYemMPJ7Micju0WSkv50dBksTuZks9O5cg4wp+t8fZ/cLY56g==
.unpackedSize: 203.5 kB

(omit)
❯ curl -sL https://registry.npmjs.org/@octokit/plugin-paginate-rest/-/plugin-paginate-rest-11.3.1.tgz | tar -xf -
❯ cat package/package.json | jq '.peerDependencies'
{
  "@octokit/core": "5"
}

Versions

Node.js v20.15.0
pnpm v9.4.0

@octokit/core 6.1.2
@octokit/rest 21.0.0
@octokit/plugin-paginate-rest 11.3.1

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: BugSomething isn't working as documentedreleased

    Type

    No type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions