fix(README): getInstallationOctokit() doesn't need destructuring
#2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfy1339
added
Type: Bug
gr2m
changed the title
getInstallationOctokit() doesn't need destructuringgetInstallationOctokit() doesn't need destructuring
|
🎉 This PR is included in version 2.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
You can also use the We also export |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey ocktokit team!
I've been playing around with consuming webhooks from a Next.js app so I'm not using probot and I need to create octokit instances manually. I believe this part of the docs is not correct according to the types I'm getting and also taking a look to the source code here https://github.com/octokit/app.js/blob/master/src/get-installation-octokit.ts#L19
Thanks!
View rendered README.md