feat: v8 #418
Merged
feat: v8 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Drop support for NodeJS v14, v16
wolfy1339
added
Type: Breaking change
BREAKING CHANGE: remove previews logic for the REST API
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (url.endsWith("/graphql")) { | ||
| if (options.mediaType.previews?.length) { | ||
| const previewsFromAcceptHeader = | ||
| headers.accept.match(/[\w-]+(?=-preview)/g) || ([] as string[]); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
|
Ready to go 🚀 |
|
Are you of the opinion that this security alert doesn't matter, since all our headers are coming from GitHub anyway and therefore won't be problematic in the way the CodeQL alert thinks? |
|
I think it's safe to mark it as won't fix, for the reasons you said |
kfcampbell
approved these changes
Jun 14, 2023
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Drop support for NodeJS v14, v16
BREAKING CHANGE: remove previews logic for the REST API