Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add /app/installation-requests to requires-app-auth paths #594

Conversation

Drew-Kimberly
Copy link
Contributor

Resolves #593

Ensures List Installation Requests for the Authenticated App use an app JWT

Before the change?

Octokit requests to GET /app/installation-requests will throw the following error:

Error: [@octokit/auth-app] installationId option is required for installation authentication.

After the change?

Octokit requests to GET /app/installation-requests will make the request with an app JWT.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link
Contributor

github-actions bot commented Apr 2, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented, or is being fixed label Apr 2, 2024
@wolfy1339 wolfy1339 merged commit f16debb into octokit:main Apr 2, 2024
8 checks passed
Copy link
Contributor

github-actions bot commented Apr 2, 2024

🎉 This PR is included in version 6.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Drew-Kimberly Drew-Kimberly deleted the fix/ISSUE-593/add-list-installation-requests-app-auth branch April 3, 2024 13:00
Copy link
Contributor

🎉 This PR is included in version 7.0.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta released Type: Bug Something isn't working as documented, or is being fixed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: /app/installation-requests missing from PATHS in requires-app-auth
2 participants