atob is not defined when building with target: Node using webpack

[thibaultdalban]

Hello,

I'm facing this error when I try to request the API. My project uses the following packages:

• "@octokit/auth-app": "^2.4.4"
• "@octokit/rest": "^17.1.4"
• "typescript": "^3.8.2"

import { createAppAuth } from "@octokit/auth-app";
import { Octokit } from "@octokit/rest"

const appOctokit = new Octokit({
  authStrategy: createAppAuth,
  auth: {
    id: APP_ID,
    privateKey: PRIVATE_KEY
  }
})
const { data } = await appOctokit.request("/app");
console.log(data)

"errorType": "ReferenceError",
"errorMessage": "atob is not defined",
"stack": [
    "ReferenceError: atob is not defined",
    "    at getDERfromPEM (/var/task/webpack:/myapp/node_modules/universal-github-app-jwt/dist-web/index.js:15:1)",
    "    at getToken (/var/task/webpack:/myapp/node_modules/universal-github-app-jwt/dist-web/index.js:50:1)",
    "    at githubAppJwt (/var/task/webpack:/myapp/node_modules/universal-github-app-jwt/dist-web/index.js:71:1)",
    "    at getAppAuthentication (/var/task/webpack:/myapp/node_modules/@octokit/auth-app/dist-web/index.js:8:37)",
    "    at getInstallationAuthentication (/var/task/webpack:/myapp/node_modules/@octokit/auth-app/dist-web/index.js:110:1)",
    "    at dist_web_hook (/var/task/webpack:/myapp/node_modules/@octokit/auth-app/dist-web/index.js:240:20)",
    ...
]

I tried to install the package atob-lite cause it was a dependency in the past https://github.com/octokit/rest.js/pull/1302, but it doesn't fix the issue.

[gr2m]

In what environment are you running your app? Server or browser?

[gr2m]

I wonder where universal-github-app-jwt is coming from, it's not a dependency of @octokit/auth-app.js?

[thibaultdalban]

Hi @gr2m,

Thank you for your quick reply!

In what environment are you running your app? Server or browser?

My app is an AWS serverless Lambda running Node V12.16.1

I wonder where universal-github-app-jwt is coming from, it's not a dependency of @octokit/auth-app.js?

I'm not sure to understand the question, but universal-github-app-jwt has been introduced in @octokit/auth-app.js by #19

[thibaultdalban]

It's strange; my app seems to be detected as running in a browser because before hitting this error, I've been requested to convert my private key using:

openssl pkcs8 -topk8 -inform PEM -outform PEM -nocrypt -in private-key.pem -out private-key-pkcs8.key

but the README indicates, Node handles both:

No conversation is needed in Node, both PKCS#1 and PKCS#8 format will work.

[thibaultdalban]

This issue webpack/webpack#5756 could explain why my app is using the code under dist-web and not dist-node.

I tested this webpack/webpack#5756 (comment) and it loads the correct code, but it's not an option because it introduces potential side effects 😕

I tried to downgrade to "@octokit/auth-app": "^2.0.1" (so before introducing the browser compatibility) and I can execute the code without issue.

[gr2m]

I'm not sure to understand the question, but universal-github-app-jwt has been introduced in @octokit/auth-app.js by #19

Sorry, I mixed up what repository I was in 🤦‍♂ please ignore my comment.

This is all a problem with creating universal libraries (and build tools), it's really a pain. There is no standard that everyone agrees on. We have a lengthy discussion here about a similar problem: gr2m/universal-user-agent#23 I hope that you find a workaround workaround there for you?

I hope that build tools add support for conditional exports, recently introduced to Node.js: https://nodejs.org/api/esm.html#esm_conditional_exports. This will be the right tool for the job, but until webpack and friends support it, it's going to be frustrating to all of us, I'm very sorry :(

[thibaultdalban]

Thank you for the explanation and the links. I will take the time to read the discussion and test the different workarounds.
I very appreciated your help ⛑️ and your reactivity!
A big THANK YOU for all your contributions to the open-source community 👍

[brunopenso]

HI, I have the same error here with AWS lambda and node 12.x and serverless framework.

package.json:
"@octokit/auth-app": "^2.4.15", "@octokit/core": "^3.1.2",
I solve the problem by commenting the line below from the serverless.yml

plugins:
  - serverless-offline
  - serverless-prune-plugin
#  - serverless-webpack
custom:
  prune:
    automatic: true
    number: 3

[apmitchell]

Thank you for the explanation and the links. I will take the time to read the discussion and test the different workarounds.
I very appreciated your help ⛑️ and your reactivity!
A big THANK YOU for all your contributions to the open-source community 👍

Did you ever find a workaround for this?