Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #508 from gera2ld/fix/scrolling #508

Merged
merged 4 commits into from
Jan 16, 2020

Conversation

gera2ld
Copy link
Contributor

@gera2ld gera2ld commented Oct 1, 2019

Fix bug introduced by #361 .
With this bug mouse scrolling does not work on Windows.

@oktapodia
Copy link
Collaborator

Thank you for your PR @gera2ld and sorry for the delay, can you please add some tests?

@gera2ld
Copy link
Contributor Author

gera2ld commented Dec 4, 2019

There are already tests for this, maybe they didn't pass when the bug is introduced to master.

@aeroreyna
Copy link

This works to solve the issue for me.
Windows 10

@oktapodia oktapodia changed the title fix: scrolling on Windows Merge pull request #508 from gera2ld/fix/scrolling Jan 16, 2020
@oktapodia oktapodia merged commit 24231df into octalmage:master Jan 16, 2020
@oktapodia
Copy link
Collaborator

Thank you for your PR

@gera2ld gera2ld deleted the fix/scrolling branch April 22, 2020 16:02
@Veiintc Veiintc mentioned this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants