Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screen capture for Mac. #242

Merged
merged 14 commits into from
Oct 16, 2016
Merged

Fix screen capture for Mac. #242

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b58962f
Starting to implement bitmap sharing.
octalmage Jan 7, 2016
fdbbff9
New screen capture code.
octalmage May 15, 2016
7cee00e
Merge branch 'master' into bitmap-save
octalmage May 15, 2016
ab802ba
Added safety checks.
octalmage May 15, 2016
cea1cae
Remove whitespace.
octalmage May 15, 2016
e2ff6cd
Space before comment.
octalmage May 15, 2016
fbadd72
Merge branch 'master' into new-screenshot-code
octalmage Oct 15, 2016
42a2562
No saving code for now.
octalmage Oct 15, 2016
4e0f44c
Remove .save.
octalmage Oct 15, 2016
d6d9e23
Fix merge conflict.
octalmage Oct 15, 2016
f58e519
Remove bitmap save method.
octalmage Oct 15, 2016
299a66d
Fix tests for higher density screens.
octalmage Oct 15, 2016
efa3582
Fixed ascii art.
octalmage Oct 15, 2016
f4707f2
Use a smarter fix for tests.
octalmage Oct 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Space before comment.
  • Loading branch information
@octalmage
octalmage committed May 15, 2016
commit e2ff6cd574036660418ced7c1f1d692bc42eb87d
4 changes: 2 additions & 2 deletions src/robotjs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,15 +793,15 @@ NAN_METHOD(saveBitmap)
MMBitmapRef bitmap;
MMImageType type = kBMPImageType;

//Get our image object from JavaScript.
// Get our image object from JavaScript.
BMP img = buildBMP(Nan::To<v8::Object>(info[0]).ToLocalChecked());

char *path;
Nan::Utf8String string(info[1]);

path = *string;

//Create the bitmap.
// Create the bitmap.
bitmap = createMMBitmap(img.image, img.width, img.height, img.byteWidth, img.bitsPerPixel, img.bytesPerPixel);

if (saveMMBitmapToFile(bitmap, path, type) != 0) {
Expand Down