Repository navigation
lwt_unix_stubs.c: fix races reported by TSan - #1094
Merged
Merged
Conversation
fixes #1026 h/t Olivier Nicole for running tsan and reporting the issue
|
From a distance, it seems to me like it should solve the data races I reported. Unfortunately, I did not write down how to reproduce these reports at the time, so I’m afraid I can’t check that the TSan reports are gone. But given the extra mutex locks they should be. |
Collaborator
Author
|
thanks for having a look :) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hopes to fix #1026
h/t @OlivierNicole for running tsan and reporting the issue