Skip to content

Prepare release 6.0 #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Prepare release 6.0 #1817

merged 3 commits into from
Feb 3, 2025

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Jan 28, 2025

No description provided.

@hhugo
Copy link
Member Author

hhugo commented Jan 28, 2025

@vouillon, do you have something else to include in the next release ?

@vouillon
Copy link
Member

I don't have anything else to include, except for #1819 and #1820.

@hhugo hhugo force-pushed the prepare-release-6.0 branch from 6385a1b to 0c57b2e Compare January 28, 2025 14:59
@OlivierNicole
Copy link
Contributor

Do you have an ETA for the release @hhugo?

@hhugo
Copy link
Member Author

hhugo commented Feb 3, 2025

Hopefully by the end of the week

@hhugo hhugo added this to the 6.0 milestone Feb 3, 2025
@hhugo
Copy link
Member Author

hhugo commented Feb 3, 2025

@vouillon, I see you have more fixes under the unix2 branch. Are some of it ready before the 6.0 release ?

@hhugo hhugo force-pushed the prepare-release-6.0 branch 2 times, most recently from 4d70479 to 632b1ad Compare February 3, 2025 22:06
@hhugo hhugo force-pushed the prepare-release-6.0 branch from 632b1ad to 84d974c Compare February 3, 2025 23:27
@hhugo hhugo merged commit 7c6c209 into master Feb 3, 2025
29 of 30 checks passed
@hhugo hhugo deleted the prepare-release-6.0 branch February 3, 2025 23:37
@vouillon
Copy link
Member

vouillon commented Feb 4, 2025

@hhugo There are some concerns from Jane Street that #1769 might be too aggressive. In particular, they are relying on the fact that the method localStorage of window has type storage t optdef readonly_prop to access safely the local storage when it is available, without crashing in other contexts (node / service workers). Also, Chrome is sending fake mousedown events without a key nor a code property.

@hhugo
Copy link
Member Author

hhugo commented Feb 4, 2025

@hhugo There are some concerns from Jane Street that #1769 might be too aggressive. In particular, they are relying on the fact that the method localStorage of window has type storage t optdef readonly_prop to access safely the local storage when it is available, without crashing in other contexts (node / service workers). Also, Chrome is sending fake mousedown events without a key nor a code property.

I'm still working on the release. You (or Janestreet) can open a PR to address the concerns.

@hhugo
Copy link
Member Author

hhugo commented Feb 4, 2025

Please move discussion to #1827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants