Skip to content

Compiler: Rework inlining #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Compiler: Rework inlining #1584

merged 1 commit into from
Mar 26, 2024

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Mar 10, 2024

Should fix #357

@vouillon, I've rebased an old branch of yours (aggressive-inlining) and changed the logic a bit so that

  • it can replace the previous "simple" optimization (inlining closure of "size" one).
  • it only duplicates other small closures if they call one of their arguments in tail position (this is an attempt at addressing Better inlining ? #357)

@hhugo hhugo requested a review from vouillon March 10, 2024 22:44
@hhugo hhugo mentioned this pull request Mar 10, 2024
@hhugo hhugo force-pushed the aggressive-inlining-hh branch from a1a16c1 to c738691 Compare March 11, 2024 10:53
@hhugo
Copy link
Member Author

hhugo commented Mar 11, 2024

@pmwhite, @TyOverby, you might want to try this PR as it could affect performance and size of artifacts.

@hhugo hhugo force-pushed the aggressive-inlining-hh branch 2 times, most recently from 4916e25 to f3d8d4f Compare March 19, 2024 21:26
@hhugo hhugo force-pushed the aggressive-inlining-hh branch from 418d991 to 9baa4e8 Compare March 26, 2024 12:13
@hhugo hhugo merged commit 4db2d9d into master Mar 26, 2024
@hhugo hhugo deleted the aggressive-inlining-hh branch March 26, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better inlining ?
2 participants