Skip to content

global_this alternative implementation #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

global_this alternative implementation #1195

wants to merge 2 commits into from

Conversation

TyOverby
Copy link
Collaborator

@TyOverby TyOverby commented Dec 24, 2021 •
edited
Loading

fix #699 by passing globalThis to the IIFE

@TyOverby TyOverby changed the title global_this attempt #2 global_this alternative implementation Dec 24, 2021
@TyOverby TyOverby mentioned this pull request Dec 24, 2021
Merged
1 task
@hhugo
Copy link
Member

hhugo commented Dec 24, 2021

We need to ship a polyfill for globalThis. Support in various engine is relatively recent

@hhugo
Copy link
Member

hhugo commented Jan 3, 2022

Closing in favor of #1193

@hhugo hhugo closed this Jan 3, 2022
@hhugo hhugo deleted the globalThis2 branch January 5, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

joo_global_object is undefined when bundled in strict mode
2 participants
@TyOverby @hhugo