Skip to content

PPX: removing the error concerning mutable fields #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2021
Merged

PPX: removing the error concerning mutable fields #1187

merged 1 commit into from
Nov 29, 2021

Conversation

rluong89
Copy link
Contributor

@rluong89 rluong89 commented Nov 29, 2021 •
edited by hhugo
Loading

I discussed with @vouillon and he doesn't see why there should be this error.
fix #1184

@hhugo
Copy link
Member

hhugo commented Nov 29, 2021

LGTM.
Can you update the Changelog and add a few tests in ppx/ppx_deriving_json/tests/ppx.mlt ?

@rluong89
Copy link
Contributor Author

Done.

@hhugo
Copy link
Member

hhugo commented Nov 29, 2021

Thanks, will merge after CI runs

@hhugo hhugo merged commit b95efb5 into ocsigen:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json cannot be derived for mutable records
2 participants
@rluong89 @hhugo