Skip to content

Fix graphics_js with separate compilation #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2020
Merged

Fix graphics_js with separate compilation #1036

merged 3 commits into from
Jul 14, 2020

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Jul 13, 2020

fix #1029
fix #1028

@hhugo
Copy link
Member Author

hhugo commented Jul 13, 2020

@adept, can you confirm this solves your issue ?

@adept
Copy link

adept commented Jul 13, 2020

@hhugo, I did:

opam pin add js_of_ocaml-lwt 'git@github.com:ocsigen/js_of_ocaml.git#tune-runtime'

rebuilt my project and can confirm that #1029 is now fixed

@hhugo hhugo merged commit f8de6da into master Jul 14, 2020
@hhugo hhugo deleted the tune-runtime branch July 14, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hhugo @adept