Skip to content

Added an observability metric event to the discovery category.#1442

Open
hmadison wants to merge 9 commits into
ocsf:mainfrom
hmadison:hm-ap/observability-metric
Open

Added an observability metric event to the discovery category.#1442
hmadison wants to merge 9 commits into
ocsf:mainfrom
hmadison:hm-ap/observability-metric

Conversation

@hmadison
Copy link
Copy Markdown
Contributor

@hmadison hmadison commented Jun 3, 2025

Related Issue:

Resolves #1421 / Pairing with @pladamgregory.

Description of changes:

This adds an event type which is captures metrics which were collected from a target entity. The goal of this class is capture relevant metrics, such as throughput metrics from netflow collectors, failed login attempt counts, or other "time series" style data which can be used to power heuristic based detections or otherwise aid in investigations.

Delete once you have confirmed the following:

  1. Did you add a single line summary of changes to Unreleased section in the CHANGELOG.md file?
  2. Have you followed the contribution guidelines?
  3. Did you run a local instance of the ocsf-server and ensure it ran without any errors/warnings?
  4. Is your PR title in sync with the description?

Comment thread dictionary.json Outdated
@hmadison hmadison force-pushed the hm-ap/observability-metric branch 2 times, most recently from d63312c to e014841 Compare June 17, 2025 13:57
@mikeradka mikeradka self-requested a review June 24, 2025 17:02
@hmadison hmadison closed this Jun 26, 2025
@hmadison hmadison force-pushed the hm-ap/observability-metric branch from 9cdc0cd to 83234cf Compare June 26, 2025 17:41
@hmadison hmadison reopened this Jun 26, 2025
@hmadison hmadison force-pushed the hm-ap/observability-metric branch from f00b129 to 25ba4b6 Compare September 23, 2025 16:54
@mikeradka mikeradka removed the v1.7.0 label Oct 3, 2025
@mikeradka
Copy link
Copy Markdown
Contributor

@hmadison Is this PR worth pursuing at this time?

@hmadison
Copy link
Copy Markdown
Contributor Author

hmadison commented Oct 7, 2025

@mikeradka I still would like to see this merged in.

@hmadison hmadison force-pushed the hm-ap/observability-metric branch from e0d3681 to fdf5b83 Compare November 4, 2025 13:03
@floydtree floydtree added the v1.8.0 PRs, Issues that will be considered for v1.8.0 label Nov 4, 2025
@hmadison hmadison added the OpenTelemetry pull requests related to OpenTelemetry label Dec 2, 2025
@hmadison
Copy link
Copy Markdown
Contributor Author

hmadison commented Dec 2, 2025

This is waiting on clarity around OpenTelemetry and OCSF's boundaries (cc @pagbabian-splunk).

@pagbabian-splunk
Copy link
Copy Markdown
Contributor

This is waiting on clarity around OpenTelemetry and OCSF's boundaries (cc @pagbabian-splunk).

Got it - yes, although since things have been moving so slowly on that front, if we want to finish this one that's ok by me if it is serving a use case. We can talk a bit more about it at tomorrow's weekly meeting if we have time (it is a 1.8 PR so we should).

Comment thread objects/observed_entity.json Outdated
zschmerber
zschmerber previously approved these changes Dec 16, 2025
Copy link
Copy Markdown
Contributor

@pagbabian-splunk pagbabian-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor description suggestion.

"name": "observability_metric_report",
"attributes": {
"observed_entity": {
"description": "The entity which produced the metric(s) were collected from. This collection process can happen either via a push from the entity to a third party service or a third party service performing an activity to interface with the entity and extract the metrics of interest.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small grammar improvement: "The entity which produced the collected metric(s)."

Signed-off-by: Mike Radka (Splunk) <91983279+mikeradka@users.noreply.github.com>
Move the line '1. Added new `observability_metric_report` event to the Discovery category. [ocsf#1442](ocsf#1442)' to 1.8.0 (was in 1.6.0 due to the age of this PR)

Signed-off-by: Mike Radka (Splunk) <91983279+mikeradka@users.noreply.github.com>
@pagbabian-splunk pagbabian-splunk removed the v1.8.0 PRs, Issues that will be considered for v1.8.0 label Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

input_needed OpenTelemetry pull requests related to OpenTelemetry v1.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants