Vulkan: Re-Create main window pipeline #8041
Conversation
- Added ImGui_ImplVulkan_ReCreateMainPipeline(...) to explicitly re-create the main window pipeline (when some of its properties are changed). - ImGui_ImplVulkan_ReCreateMainPipeline(...) does not implicitly use ImGui_ImplVulkan_InitInfo::PipelineRenderingCreateInfo, but a function parameter. - The main window pipeline is created only if possible during ImGui_ImplVulkan_Init(...) (if a render pass or rendering info are given), else it should be created with ImGui_ImplVulkan_ReCreateMainPipeline(...)
|
I will also write an extension of these changes for the docking branch. |
- The default behavior of imgui_impl_vulkan does not change (no color correction is applied). - A color correction method is decided at pipeline compile time (through a vulkan specialization constant) - Color correction parameters can either be set at pipeline compile time (static mode), or through push_constant (dynamic mode, default) - A gamma correction mode is implemented (and an extra alpha gamma correction). - New color modes can easily be added.
|
I also added a optional color correction to the imgui fragment shader. |
…ing static color correction parameters
|
? |
|
I will re-open it soon (this evening or tomorrow) with more changes (and a docking version), I did not want to burden you a merge of an outdated version. |
|
You can push or force push to a same PR to update it! But FYI doing multiple unrelated things in a same PR is the best way to get it to take years to get looked at. Providing clear rational / proof / exemples for everything would be helpful too. Vulkan related changes are notoriously slow because people seem often happy to not explore all angles. (But an unmerged PR is often better than no PR, as the visibility helps people align toward a solution) Thanks! |
R.