Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #582: Make ppss.yaml copy directions more explicit #580

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

graceful-coder
Copy link
Collaborator

@graceful-coder graceful-coder commented Jan 29, 2024

Fix #582.

Changes proposed in this PR:

  • Added a small code block to the Sim flow readme for cp ppss.yaml to my_ppss.yaml

Added code block to cp ppss.yaml to my_ppss.yaml
@trentmc trentmc changed the title Added a small code block to improve copy-paste to follow the sim flow Fix #582: Make ppss.yaml copy directions more explicit Jan 30, 2024
Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, every PR should be accompanied by a github issue. So I created one: #582. Then I updated this PR to explicitly point to that issue.

As for the changes itself:

  • this is good
  • but it's only for predictoor.md so far
  • you need to make an identical change in trader.md

(The newly-created github issue lists this as two specific TODOS.)

Copy link
Member

@idiom-bytes idiom-bytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straightforward update, this looks good. I'm approving.

@graceful-coder graceful-coder merged commit 29238fb into main Jan 30, 2024
5 checks passed
@graceful-coder graceful-coder deleted the sim-readme-minor-change branch January 30, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Make ppss.yaml copy directions more explicit
3 participants