Open
Conversation
ndrpp
requested review from
alexcos20,
andreip136,
bogdanfazakas,
denisiuriet and
giurgiur99
as code owners
Contributor
|
What happens if LOG_DB is false and logs are not saved in db? Can we at leas download the exceptions from /logs dir? |
Member
Author
If LOG_DB is false it will return an empty array. Should we download the exceptions? |
alexcos20
requested changes
Feb 11, 2026
Member
alexcos20
left a comment
alexcos20
left a comment
There was a problem hiding this comment.
why not use the new handler in src/components/httpRoutes/logs.ts ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this PR: