Skip to content

ci: remove the r2o-check workflow before the oceanmodeling move - #247

Merged
mansurjisan merged 1 commit into
developfrom
chore/remove-r2o-check
Oct 19, 2026
Merged

mansurjisan merged 1 commit into
developfrom
chore/remove-r2o-check

Conversation

@mansurjisan

@mansurjisan mansurjisan commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Note: this PR was merged with part 1 only. Part 2 (the self-hosted Docker parity jobs) was pushed after the merge and is in #248.

Two GitHub Actions cleanups before nos-workflow moves to the oceanmodeling org.

1. r2o-check. Removes the r2o-check GitHub Actions workflow (.github/workflows/r2o-check.yml, "NCO Compliance") from nos-workflow before the repository moves to the oceanmodeling org. The r2o-check tool stays with its maintainer and is not part of the move.

  • The workflow ran pip install r2o-check and an advisory r2o-check lint on every PR (the compliance check). It never gated a merge: develop has no branch protection or required checks.
  • Nothing else in the repository references it (no code, tests, docs or other workflows).

2. Self-hosted Docker parity jobs. Removes the four Docker parity (self-hosted) jobs (prep, post, nowcast, forecast) from .github/workflows/stage_parity.yml.

  • They needed a self-hosted runner labelled secofs-docker and the repository variable ENABLE_DOCKER_PARITY=1. No runner is registered, so the jobs were always skipped.
  • The four hosted jobs in the same workflow (manifest schema and diff helpers) are unchanged, and nothing depended on the removed jobs.
  • The header comment now describes only the hosted jobs.

Kept: hercules-ci.yml.

Type of change

  • Maintenance (refactor, cleanup, CI, comments)

Change characteristics

  • Changes outputs (values, COMOUT files or names, archives)? NO
  • Breaking change to existing functionality? NO (the compliance check and the skipped self-hosted parity checks no longer appear on PRs)
  • Requires a nos-utils submodule bump (nos-workflow) or a paired nos-workflow change (nos-utils)? NO
  • Requires new or regenerated fix files on the machine? NO
  • Requires a re-prep or a new hotstart before the next cycle? NO
  • Machines affected: none

How has this been tested?

  • CI-only change; no code changes. git grep -i r2o on this branch finds nothing.
  • stage_parity.yml still parses as YAML; its jobs are the four hosted *-manifest-and-helpers jobs.

Checklist

  • Dependent PRs merged and published (nos-utils before any submodule bump): none; merge before the repository transfer
  • pytest suite passes (no code changes)
  • Existing operational behavior preserved, or the change is called out above
  • No edits to a shared FIXofs while it is cycling
  • Self-review done; yaml comments and docstrings updated where behavior changed
  • No markdown files added to the repo

@mansurjisan
mansurjisan merged commit 84f23f9 into develop Oct 19, 2026
@mansurjisan mansurjisan changed the title ci: remove the r2o-check workflow before the oceanmodeling move ci: remove r2o-check and the self-hosted Docker parity jobs before the oceanmodeling move Oct 19, 2026
@mansurjisan mansurjisan changed the title ci: remove r2o-check and the self-hosted Docker parity jobs before the oceanmodeling move ci: remove the r2o-check workflow before the oceanmodeling move Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant