Repository navigation
ci: remove the r2o-check workflow before the oceanmodeling move - #247
Merged
Merged
Conversation
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: this PR was merged with part 1 only. Part 2 (the self-hosted Docker parity jobs) was pushed after the merge and is in #248.
Two GitHub Actions cleanups before nos-workflow moves to the
oceanmodelingorg.1. r2o-check. Removes the r2o-check GitHub Actions workflow (
.github/workflows/r2o-check.yml, "NCO Compliance") from nos-workflow before the repository moves to theoceanmodelingorg. The r2o-check tool stays with its maintainer and is not part of the move.pip install r2o-checkand an advisoryr2o-check linton every PR (thecompliancecheck). It never gated a merge:develophas no branch protection or required checks.2. Self-hosted Docker parity jobs. Removes the four
Docker parity (self-hosted)jobs (prep, post, nowcast, forecast) from.github/workflows/stage_parity.yml.secofs-dockerand the repository variableENABLE_DOCKER_PARITY=1. No runner is registered, so the jobs were always skipped.Kept:
hercules-ci.yml.Type of change
Change characteristics
compliancecheck and the skipped self-hosted parity checks no longer appear on PRs)How has this been tested?
git grep -i r2oon this branch finds nothing.stage_parity.ymlstill parses as YAML; its jobs are the four hosted*-manifest-and-helpersjobs.Checklist