Repository navigation
Implement the first implementation of STOFS Pacific - #238
Open
SorooshMani-NOAA wants to merge 2 commits into
Open
SorooshMani-NOAA wants to merge 2 commits into
SorooshMani-NOAA wants to merge 2 commits into
Conversation
Comment on lines
+84
to
+85
| rtofs_3d_region: "" | ||
| rtofs_freq: daily |
Collaborator
Author
There was a problem hiding this comment.
These would need further commits in utils for rtofs processing
There was a problem hiding this comment.
🟡 Changes recommended
Missing Pacific registration and incomplete coupled-mode defaults prevent a usable workflow configuration.
2 open findings
What changed in this PR
Introduces initial STOFS-3D Pacific configuration within the existing SCHISM workflow.
Changes:
- Adds Pacific grid, forcing, runtime, and post-processing settings.
- Adds a standalone overlay with static river inputs.
- Sets an explicit Atlantic ADT datum offset.
| File | Description |
|---|---|
| parm/systems/stofs_3d_pac_ufs.yaml | Adds the initial Pacific system configuration. |
| parm/systems/stofs_3d_pac_ufs_standalone.yaml | Selects standalone execution and static river files. |
| parm/systems/stofs_3d_atl_ufs.yaml | Sets the ADT datum offset to -0.45. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| _base: schism | ||
|
|
||
| system: | ||
| name: stofs_3d_pac |
Collaborator
Author
There was a problem hiding this comment.
I added a descriptor registration: ab3b50f
| prefix: stofs_3d_pac_ufs | ||
|
|
||
| execution: | ||
| mode: ufs # ufs (default, UFS-Coastal DATM) | standalone (classic SCHISM sflux) |
Collaborator
Author
There was a problem hiding this comment.
This is a draft; I'll revisit this when standalone works as expected. At this point I just want to keep the file organization the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Change characteristics
How has this been tested?
not tested yet
Checklist