Repository navigation
STOFS-3D-ATL coupled: write and publish verticalVelocity and diffusivity (as ops and standalone) - #224
Open
mansurjisan wants to merge 2 commits into
Open
STOFS-3D-ATL coupled: write and publish verticalVelocity and diffusivity (as ops and standalone)#224mansurjisan wants to merge 2 commits into
mansurjisan wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the STOFS-3D-ATL UFS-coupled run (DATM + CMEPS + SCHISM, OLDIO) write the verticalVelocity and diffusivity field stacks, as the standalone (scribe) run and ops v3.1.5 do.
Cause: the coupled param.nml had
iof_hydro(17)(vertical velocity) andiof_hydro(21)(vertical eddy diffusivity) at 0, while the ops template and the standalone template have both at 1. The coupled schout therefore never held either field; the WCOSS2 coupled post log lists only['evaporation', 'wind_stress', 'dahv']as unsplit variables.OLDIO supports both fields in the existing build (
schism_step.F90:vertical_velocityunderiof_hydro(17),diffusivityunderiof_hydro(21)), so no executable change is needed. The coupled splitter (schism_combine_outputs.py,convert_schout_to_split) did not map the OLDIO names, so the flags alone would have left both fields in schout and unpublished. Changes:fix/stofs_3d_atl_ufs/stofs_3d_atl_ufs.param.nml:iof_hydro(17) = 1,iof_hydro(21) = 1; header updated.iof_hydro(2)(air pressure) stays 0.ush/schism_combine_outputs.py:vertical_velocity->verticalVelocity_N.ncanddiffusivity->diffusivity_N.nc, the scribe names that the fields product, the ops attribute step and the archive globs already handle.iof_hydro(2); two new splitter tests (fields present and absent).Cost: each field is 3,052,121 nodes x 49 levels x 4 bytes, about 0.6 GB per hourly record before compression. The coupled 3D output goes from 5 arrays (zcor, temp, salt, hvel x2) to 7, so about +40% on 3D combine time and 3D staging/archive volume per cycle.
COMOUT: the split 3D stacks are written uncompressed, so the two fields add about 2 x 120 hourly records x 0.6 GB, roughly 144 GB per cycle, to COMOUT staging (plus their deflated copies inside the staged schout files). Check ptmp space before cycling.
Also removes the run-guide limitation line saying coupled runs do not write these fields, and updates the splitter docstring.
Type of change
Change characteristics
fields.verticalVelocity,fields.diffusivity), no change to existing ones or to model resultsstofs_3d_atl_ufs.param.nmlmust be in the FIXofs the coupled cards readHow has this been tested?
Checklist